You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/12 01:12:00 UTC
[jira] [Commented] (BEAM-3464) NexmarkLauncher should not cancel
jobs once the input events has been reached
[ https://issues.apache.org/jira/browse/BEAM-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323338#comment-16323338 ]
ASF GitHub Bot commented on BEAM-3464:
--------------------------------------
scwhittle opened a new pull request #4398: [ BEAM-3464] Fix NexmarkLauncher to not cancel jobs otherwise successful jobs
URL: https://github.com/apache/beam/pull/4398
Instead rely on watermark completion to terminate the job successfully.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> NexmarkLauncher should not cancel jobs once the input events has been reached
> -----------------------------------------------------------------------------
>
> Key: BEAM-3464
> URL: https://issues.apache.org/jira/browse/BEAM-3464
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: Trivial
>
> NexmarkLauncher monitors the nexmark job and cancels it in several cases: if it gets stuck, has fatal errors or the input processed counter equals the desired amount.
> Cancelling based upon the processed counter is problematic for the following reasons:
> - Dataflow (and other runners?) streaming counters are non-determinisitic and thus the cancellation is deterministic
> - The event counter is from the beginning stage of the pipeline and the pipeline may have internally buffered data
> This cancellation is also unnessary as once all the events are processed, the nexmark source watermark goes to infinity and the pipeline will terminate due to all watermarks going to infinity after it completes draining.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)