[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1988: [CALCITE-4019] Change SqlInsert getOperandList method

[GitBox <gi...@apache.org>]

yanlin-Lynn commented on a change in pull request #1988:
URL: https://github.com/apache/calcite/pull/1988#discussion_r430126757



##########
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##########
@@ -5747,6 +5748,17 @@ public void subTestIntervalMonthFailsValidation() {
         .ok("INTERVAL '0' MONTH(0)");
   }
 
+  @Test void testSqlParserPosPlus() throws Exception {
+    final String sql = "insert into emps select * from emps";
+    final SqlNode sqlNode = getSqlParser(sql).parseStmt();
+    sqlNode.accept(new SqlShuttle() {
+      @Override public SqlNode visit(SqlIdentifier identifier) {
+        return new SqlIdentifier(identifier.names,
+            identifier.getParserPosition());
+      }
+    });
+  }

Review comment:
       how about add  some checks for the result of accept




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org