You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/09/23 00:39:53 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2738:
[GOBBLIN-885]Fix orc-Compaction bug in non-dedup mode and add unit-test
codecov-io commented on issue #2738: [GOBBLIN-885]Fix orc-Compaction bug in non-dedup mode and add unit-test
URL: https://github.com/apache/incubator-gobblin/pull/2738#issuecomment-533933677
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=h1) Report
> Merging [#2738](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/11ecc32439478474a7c72d1f2a950eb13c0bd7f9?src=pr&el=desc) will **increase** coverage by `40.99%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2738 +/- ##
=============================================
+ Coverage 4.14% 45.14% +40.99%
- Complexity 738 8781 +8043
=============================================
Files 1886 1886
Lines 70501 70500 -1
Branches 7736 7736
=============================================
+ Hits 2924 31827 +28903
+ Misses 67269 35727 -31542
- Partials 308 2946 +2638
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bblin/compaction/mapreduce/orc/OrcValueMapper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNWYWx1ZU1hcHBlci5qYXZh) | `78.87% <100%> (+78.87%)` | `16 <1> (+16)` | :arrow_up: |
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `56.3% <0%> (+1.35%)` | `27% <0%> (+2%)` | :arrow_up: |
| [...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==) | `83.6% <0%> (+1.63%)` | `9% <0%> (+1%)` | :arrow_up: |
| [...rg/apache/gobblin/runtime/FsDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZS5qYXZh) | `73.8% <0%> (+1.78%)` | `35% <0%> (+1%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh) | `1.85% <0%> (+1.85%)` | `1% <0%> (+1%)` | :arrow_up: |
| [.../java/org/apache/gobblin/runtime/TaskExecutor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza0V4ZWN1dG9yLmphdmE=) | `45.05% <0%> (+2.19%)` | `9% <0%> (+1%)` | :arrow_up: |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `58.12% <0%> (+3.3%)` | `31% <0%> (+5%)` | :arrow_up: |
| ... and [1080 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2738/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=footer). Last update [11ecc32...b9544a2](https://codecov.io/gh/apache/incubator-gobblin/pull/2738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services