You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2017/11/28 10:06:14 UTC
Review Request 64115: HIVE-18160: Jar localization during session
initialization is slow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/
-----------------------------------------------------------
Review request for hive and Sergey Shelukhin.
Bugs: HIVE-18160
https://issues.apache.org/jira/browse/HIVE-18160
Repository: hive-git
Description
-------
HIVE-18160: Jar localization during session initialization is slow
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15c4cabcdbd666af8a9cb8022b8898a8a72
Diff: https://reviews.apache.org/r/64115/diff/1/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 64115: HIVE-18160: Jar localization during session
initialization is slow
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/#review192065
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 721 (patched)
<https://reviews.apache.org/r/64115/#comment270074>
Fixed. Moved to getSha method
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 773 (patched)
<https://reviews.apache.org/r/64115/#comment270075>
Actually this is not required. I was experimenting to see if this performed better over streaming version but it did not. I will revert this back to streaming version.
- Prasanth_J
On Nov. 28, 2017, 10:06 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64115/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 10:06 a.m.)
>
>
> Review request for hive and Sergey Shelukhin.
>
>
> Bugs: HIVE-18160
> https://issues.apache.org/jira/browse/HIVE-18160
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18160: Jar localization during session initialization is slow
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15c4cabcdbd666af8a9cb8022b8898a8a72
>
>
> Diff: https://reviews.apache.org/r/64115/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 64115: HIVE-18160: Jar localization during session
initialization is slow
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/#review192063
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 129 (patched)
<https://reviews.apache.org/r/64115/#comment270067>
nit: final?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 721 (patched)
<https://reviews.apache.org/r/64115/#comment270068>
should it only log "computed..." and the time when actually computing it?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
Lines 773 (patched)
<https://reviews.apache.org/r/64115/#comment270069>
hmm.. why is this necessary? it should still be possible to use the streaming version
- Sergey Shelukhin
On Nov. 28, 2017, 10:06 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64115/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 10:06 a.m.)
>
>
> Review request for hive and Sergey Shelukhin.
>
>
> Bugs: HIVE-18160
> https://issues.apache.org/jira/browse/HIVE-18160
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18160: Jar localization during session initialization is slow
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15c4cabcdbd666af8a9cb8022b8898a8a72
>
>
> Diff: https://reviews.apache.org/r/64115/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 64115: HIVE-18160: Jar localization during session
initialization is slow
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 9:43 p.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
Minor fix.
Bugs: HIVE-18160
https://issues.apache.org/jira/browse/HIVE-18160
Repository: hive-git
Description
-------
HIVE-18160: Jar localization during session initialization is slow
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15
Diff: https://reviews.apache.org/r/64115/diff/3/
Changes: https://reviews.apache.org/r/64115/diff/2-3/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 64115: HIVE-18160: Jar localization during session
initialization is slow
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64115/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 9:42 p.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
Addressed review comments.
Bugs: HIVE-18160
https://issues.apache.org/jira/browse/HIVE-18160
Repository: hive-git
Description
-------
HIVE-18160: Jar localization during session initialization is slow
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 7a7fe15
Diff: https://reviews.apache.org/r/64115/diff/2/
Changes: https://reviews.apache.org/r/64115/diff/1-2/
Testing
-------
Thanks,
Prasanth_J