[GitHub] jerrypeng commented on a change in pull request #1845: Functions schema integration

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #1845: Functions schema integration
URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r193865469
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java
 ##########
 @@ -49,14 +54,11 @@ public JavaInstance(InstanceConfig config, Object userClassObject,
                  PulsarClient pulsarClient,
                  Source source) {
         // TODO: cache logger instances by functions?
-        Logger instanceLog = LoggerFactory.getLogger("function-" + config.getFunctionDetails().getName());
-
-        if (source instanceof PulsarSource) {
 
 Review comment:
   Why did we get rid of this logic? We need to set ContextImpl accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services