You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Yansongsongsong (via GitHub)" <gi...@apache.org> on 2023/04/29 08:56:18 UTC
[GitHub] [incubator-opendal] Yansongsongsong commented on a diff in pull request #2162: [Still working now]feat: downgrade glibc that nodejs binding reply on to 2.11 with zig
Yansongsongsong commented on code in PR #2162:
URL: https://github.com/apache/incubator-opendal/pull/2162#discussion_r1181021766
##########
.github/workflows/bindings_nodejs.yml:
##########
@@ -101,10 +101,14 @@ jobs:
cache-dependency-path: "bindings/nodejs/yarn.lock"
- name: Corepack
run: corepack enable
+ - name: Install ziglang
+ uses: goto-bus-stop/setup-zig@v1
Review Comment:
true.
for now, i think we have several options:
1. change version the base image of ubuntu that support 2.11- glibc.
2. use zig to build such one nodejs binding. here is the references:
- [how napi use zig to build binding](https://github.com/napi-rs/cross-build/blob/main/.github/workflows/pure-rust-build-on-linux.yml#L47)
- [relation between zig target version and glibc version](https://github.com/napi-rs/napi-rs/issues/1540#issuecomment-1483103586)
- [how swc to do so](https://github.com/swc-project/swc/actions/runs/2150531101/workflow)
i am still finding any way to work around. but i am not familiar with github action staff and napi.
it is a little bit hard to trigger the nodejs bindning github action. so i create this PR directly. sorry for thsi
##########
.github/workflows/bindings_nodejs.yml:
##########
@@ -101,10 +101,14 @@ jobs:
cache-dependency-path: "bindings/nodejs/yarn.lock"
- name: Corepack
run: corepack enable
+ - name: Install ziglang
+ uses: goto-bus-stop/setup-zig@v1
Review Comment:
true.
for now, i think we have several options:
1. change version the base image of ubuntu that support 2.11- glibc.
2. use zig to build such one nodejs binding. here is the references:
- [how napi use zig to build binding](https://github.com/napi-rs/cross-build/blob/main/.github/workflows/pure-rust-build-on-linux.yml#L47)
- [relation between zig target version and glibc version](https://github.com/napi-rs/napi-rs/issues/1540#issuecomment-1483103586)
- [how swc to do so](https://github.com/swc-project/swc/actions/runs/2150531101/workflow)
i am still finding any way to work around. but i am not familiar with github action staff and napi.
it is a little bit hard to trigger the nodejs bindning github action. so i create this PR directly. sorry for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org