[GitHub] piiswrong closed pull request #9180: fix parameter overwrite in _generate_symbol_function_code

[GitBox <gi...@apache.org>]

piiswrong closed pull request #9180: fix parameter overwrite in _generate_symbol_function_code
URL: https://github.com/apache/incubator-mxnet/pull/9180
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/mxnet/symbol/register.py b/python/mxnet/symbol/register.py
index cf279d1403..7b293f5fbe 100644
--- a/python/mxnet/symbol/register.py
+++ b/python/mxnet/symbol/register.py
@@ -143,14 +143,14 @@ def %s(%s):"""%(func_name, ', '.join(signature)))
             code.append("""
     kwargs.update(AttrScope.current.get(attr))
     sym_kwargs = dict()
-    keys = []
-    vals = []
-    for k, v in kwargs.items():
-        if isinstance(v, SymbolBase):
-            sym_kwargs[k] = v
+    _keys = []
+    _vals = []
+    for _k, _v in kwargs.items():
+        if isinstance(_v, SymbolBase):
+            sym_kwargs[_k] = _v
         else:
-            keys.append(k)
-            vals.append(v)""")
+            _keys.append(_k)
+            _vals.append(_v)""")
             # NDArray args
             for name in ndarg_names: # pylint: disable=redefined-argument-from-local
                 code.append("""
@@ -162,18 +162,18 @@ def %s(%s):"""%(func_name, ', '.join(signature)))
             for name in kwarg_names: # pylint: disable=redefined-argument-from-local
                 code.append("""
     if %s is not _Null:
-        keys.append('%s')
-        vals.append(%s)"""%(name, name, name))
+        _keys.append('%s')
+        _vals.append(%s)"""%(name, name, name))
             # dtype
             if dtype_name is not None:
                 code.append("""
     if %s is not _Null:
-        keys.append('%s')
-        vals.append(np.dtype(%s).name)"""%(dtype_name, dtype_name, dtype_name))
+        _keys.append('%s')
+        _vals.append(np.dtype(%s).name)"""%(dtype_name, dtype_name, dtype_name))
 
             code.append("""
     name = NameManager.current.get(name, '%s')
-    return _symbol_creator(%d, None, sym_kwargs, keys, vals, name)"""%(
+    return _symbol_creator(%d, None, sym_kwargs, _keys, _vals, name)"""%(
         func_name.lower(), handle.value))
 
     if signature_only:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services