[jira] [Comment Edited] (OAK-2986) RDB: switch to tomcat datasource implementation

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738987#comment-14738987 ] 

Julian Reschke edited comment on OAK-2986 at 9/10/15 4:45 PM:
--------------------------------------------------------------

Re-opening because making this a test dependency breaks unit tests in oak-jcr -- sorry for the commit noise.

The new plan is to keep RDBDataSourceFactory in main, but make the tomcat pool dependency a test dependency, relying on reflection. We can later discuss whether the factory should be moved.


was (Author: reschke):
Re-opening because making this a test dependency breaks unit tests in oak-jcr

> RDB: switch to tomcat datasource implementation 
> ------------------------------------------------
>
>                 Key: OAK-2986
>                 URL: https://issues.apache.org/jira/browse/OAK-2986
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: rdbmk
>    Affects Versions: 1.2.4, 1.3.5, 1.0.19
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: resilience
>             Fix For: 1.3.6
>
>         Attachments: OAK-2986.diff, OAK-2986.diff
>
>
> See <https://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html>.
> In addition, this is the datasource used in Sling's datasource service, so it's closer to what people will use in practice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)