[GitHub] [skywalking] wu-sheng commented on a change in pull request #5424: Add superdataset replicas number config

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5424:
URL: https://github.com/apache/skywalking/pull/5424#discussion_r481152383



##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
##########
@@ -38,6 +39,12 @@
     private int superDatasetIndexShardsFactor = 5;
     @Setter
     private int indexReplicasNumber = 0;
+    /**
+     * @since 8.2.0, the replicas number is for super size dataset record replicas number
+     * @see SuperDataset
+     */
+    @Setter
+    private int superDatasetIndexReplicasNumber = 0;

Review comment:
       As you moved all superset config in one place in the doc and config file, please do the same thing for the config class
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org