You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/03/29 05:22:26 UTC
[GitHub] [beam] dependabot[bot] opened a new pull request, #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
dependabot[bot] opened a new pull request, #26024:
URL: https://github.com/apache/beam/pull/26024
Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero) from 1.0.0-rc.1 to 1.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tetratelabs/wazero/releases">github.com/tetratelabs/wazero's releases</a>.</em></p>
<blockquote>
<h2>v1.0.1</h2>
<p>wazero v1.0.1 fixes a stdio glitch, improves performance and polishes documentation. We decided to cut an early patch mainly to ensure python works properly.</p>
<h2>Python repl hang</h2>
<p>Despite trying many things prior to v1.0.0, a glitch escaped us. <a href="https://github.com/evacchi"><code>@evacchi</code></a> tried the VMware Labs <a href="https://github.com/vmware-labs/webassembly-language-runtimes/pkgs/container/python-wasm">python-wasm</a>, and noticed a repl hang. Edo and <a href="https://github.com/achille-roussel"><code>@achille-roussel</code></a> collaborated on a fix, which also ended up deleting tricky code. He verified python-wasm works, and <a href="https://github.com/ncruces"><code>@ncruces</code></a> verified <a href="https://github.com/ncruces/dcraw">dcraw</a> still works as well. Thank these folks for the teamwork and rigor!</p>
<h2>Optimizations</h2>
<p>Due to the nature of our team, you can expect optimizations in every release. A lot of work by <a href="https://github.com/mathetake"><code>@mathetake</code></a> has been optimization both from line count and performance. There were only several days duration since v1.0.0, the culmination of work by Takeshi and <a href="https://github.com/evacchi"><code>@evacchi</code></a> (with review support by <a href="https://github.com/achille-roussel"><code>@achille-roussel</code></a>) resulted in less code and a slight bump in performance in an end user benchmark:</p>
<pre><code>goos: darwin
goarch: arm64
pkg: github.com/dapr/components-contrib/bindings/wasm
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
Example-12 12.11µ ± 2% 12.02µ ± 1% ~ (p=0.132 n=6)
<p>pkg: github.com/dapr/components-contrib/middleware/http/wasm
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
Native/rewrite/rewrite-12 573.7n ± 0% 575.0n ± 0% ~ (p=0.240 n=6)
Tinygo/rewrite/rewrite-12 1.161µ ± 1% 1.155µ ± 1% -0.52% (p=0.026 n=6)
Wat/rewrite/rewrite-12 986.2n ± 0% 988.4n ± 1% ~ (p=0.485 n=6)
geomean 869.3n 869.0n -0.03%
</code></pre></p>
<h2>Docs</h2>
<p>Our documentation improved in the last few days as well: <a href="https://github.com/jcchavezs"><code>@jcchavezs</code></a> fixed some glitches on our home page around trying out wazero, <a href="https://github.com/jerbob92"><code>@jerbob92</code></a> added PDFium tools to our <a href="https://wazero.io/community/users/">users page</a>, and <a href="https://github.com/codefromthecrypt"><code>@codefromthecrypt</code></a> implemented <a href="https://github.com/Xe"><code>@Xe</code></a>'s suggestion to improve our <a href="https://pkg.go.dev/github.com/tetratelabs/wazero#ModuleConfig">our walltime clock</a> documentation. We really appreciate the pro-activity on user facing documentation!</p>
<h2>v1.0.0</h2>
<p>wazero v1.0.0 completes our six month pre-release period and begins our compatibility promise. We will use semantic versions to label releases, and not break APIs we've exposed as non-experimental.</p>
<p>Those not familiar with wazero can check out <a href="https://tetrate.io/blog/introducing-wazero-from-tetrate/">this blog</a> which overviews the zero dependency runtime. You can also check out <a href="https://wazero.io">our website</a> especially the <a href="https://wazero.io/community/">community</a> and <a href="https://wazero.io/community/users/">users</a> pages.</p>
<p>Many of you have been following along with our <a href="https://github.com/tetratelabs/wazero/releases">pre-releases</a> over the last 6 months. We did introduce change since v1.0.0-rc.2 with a particularly notable feature we call "anonymous modules". So, let's talk about that first.</p>
<h2>Anonymous modules</h2>
<p>There are two main ways wazero is used for high-volume request handling. One way is pooling modules and the other is instantiating per-request.</p>
<p>The pool approach is used for functions designed to be invoked many times, such as <a href="https://http-wasm.io/">http-wasm</a>'s handler functions. A host, such a <a href="https://docs.dapr.io/reference/components-reference/supported-middleware/middleware-wasm/">dapr</a> keeps a pool of modules, and checks one out per request.</p>
<p>The re-instantiate approach is where you know you can't re-use a module, because the code is not safe to invoke more than once. For example, WASI commands are not safe to re-invoke. So, you have to instantiate a fresh module per request. You can also re-instantiate for higher security on otherwise safe functions.</p>
<p>The latter case was expensive before, because we had to make sure each request had not just a new module, but also a unique name in the runtime. You would see things like this to do that.</p>
<pre lang="go"><code></tr></table>
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/tetratelabs/wazero/commit/e188b646f72492dae68af5a1eb833962bf459764"><code>e188b64</code></a> godoc: clarifies UTC on clock sources (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1300">#1300</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/54ba876002cc8d604f282cdd7dae7f0810961d32"><code>54ba876</code></a> interpreter: add u1, u2 int64 to <code>interpreterOp</code> (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1298">#1298</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/d63813a8300a85099480c3f5f988813105509b2e"><code>d63813a</code></a> fs: stat and cache mode for stdio devices (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1295">#1295</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/fa722dd9e3704edb6c3fb59891121ab7e78dbb71"><code>fa722dd</code></a> Implements api.Function directly over engine specific callEngine (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1297">#1297</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/0857336746c59cd74a2c4e960855e9a60cf0fa89"><code>0857336</code></a> Removes wasm.FunctionInstance type (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1294">#1294</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/9a87d2628b6eff04ccc4513f3bffb48e3c2290c0"><code>9a87d26</code></a> Removes validatedActiveElementSegment (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1292">#1292</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/a9829b627b55762c22776bb6bfb6646d8e50502d"><code>a9829b6</code></a> Add pdfium-cli to users (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1293">#1293</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/cd606bde046234178ca4392812b65839bfad2a8d"><code>cd606bd</code></a> Refactors NewModuleEngine and NewCallEngine (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1291">#1291</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/a4226906cf30ba5261d2fab2ff4df62a8109d6ea"><code>a422690</code></a> Deletes wasm.CallCtx (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1280">#1280</a>)</li>
<li><a href="https://github.com/tetratelabs/wazero/commit/721950abc52e13032f3ec9c74504c15a25962550"><code>721950a</code></a> docs: adds import to example. (<a href="https://redirect.github.com/tetratelabs/wazero/issues/1288">#1288</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/tetratelabs/wazero/compare/v1.0.0-rc.1...v1.0.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26024:
URL: https://github.com/apache/beam/pull/26024#issuecomment-1492392926
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26024:
URL: https://github.com/apache/beam/pull/26024#issuecomment-1487996165
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #26024:
URL: https://github.com/apache/beam/pull/26024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26024:
URL: https://github.com/apache/beam/pull/26024#issuecomment-1492383491
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26024: Bump github.com/tetratelabs/wazero from 1.0.0-rc.1 to 1.0.1 in /sdks
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26024:
URL: https://github.com/apache/beam/pull/26024#issuecomment-1492389753
## [Codecov](https://codecov.io/gh/apache/beam/pull/26024?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26024](https://codecov.io/gh/apache/beam/pull/26024?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ca9322) into [master](https://codecov.io/gh/apache/beam/commit/af5e0a85cc81acfdada38bfb1b2bed4294a608b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af5e0a8) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26024 +/- ##
==========================================
- Coverage 71.43% 71.43% -0.01%
==========================================
Files 782 782
Lines 102848 102848
==========================================
- Hits 73472 73471 -1
Misses 27900 27900
- Partials 1476 1477 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `54.08% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26024/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org