[GitHub] jeffreythewang opened a new pull request #6400: [sqllab][bugfix] Set default limit on creation of new QE and on run

[GitBox <gi...@apache.org>]

jeffreythewang opened a new pull request #6400: [sqllab][bugfix] Set default limit on creation of new QE and on run
URL: https://github.com/apache/incubator-superset/pull/6400
 
 
   An extension of https://github.com/apache/incubator-superset/pull/4941.
   
   Query editors don't have a `queryLimit` field unless the user explicitly sets a limit (via limit control field in SQL Lab), so no limit would be applied in some cases.
   
   This PR:
   * sets the `defaultLimit` on new tabs created via SQL Lab new tab functionality
   * sets the `queryLimit` to `defaultQueryLimit` if the existing `queryEditor` does not have a `queryLimit` loaded into state yet.
   
   There are [some other cases](https://github.com/apache/incubator-superset/blob/master/superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx#L48) where the `queryLimit` would not exist on the `queryEditor`, but those should be covered by the 2nd bullet point mentioned above.
   
   @graceguo-supercat @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org