You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/26 13:59:20 UTC

[GitHub] [calcite] asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object
URL: https://github.com/apache/calcite/pull/1071#issuecomment-476654369
 
 
   Overall LGTM. The only thing I'm debating is what arguments to provide to constructor:
   1. `GemfireCache cache, Iterable<String> names` - current version
   2. `GemfireCache cache, Predicate<String> filter`
   3. `Iterable<Region<?,?>> regions`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services