[jira] [Commented] (AVRO-3634) Implement schema for missing types

["Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615023#comment-17615023 ] 

Martin Tzvetanov Grigorov commented on AVRO-3634:
-------------------------------------------------

I agree for `bool`! Please send a PR!

But `u64` (unsigned!) won't fit inside Schema::Long (signed!).

`u32` fits in Schema::Long - https://github.com/apache/avro/blame/63c58f3b29d20ba94a6c68d9e4c09816d448bf34/lang/rust/avro/src/schema.rs#L1836

> Implement schema for missing types
> ----------------------------------
>
>                 Key: AVRO-3634
>                 URL: https://issues.apache.org/jira/browse/AVRO-3634
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>    Affects Versions: 1.11.1
>            Reporter: Jimmy Pramosi
>            Priority: Trivial
>              Labels: easyfix
>
> Hello,
> I would like to suggest to implement a schema for the type 'bool' and maybe 'u64'.
> The change is pretty trivial and involves adding
> {code:java}
> impl_schema!(bool, Schema::Boolean);
> impl_schema!(u64, Schema::Long);{code}
> to
> [https://github.com/apache/avro/blob/63c58f3b29d20ba94a6c68d9e4c09816d448bf34/lang/rust/avro/src/schema.rs#L1830]
>  
> Best Regards,
> Jimmy



--
This message was sent by Atlassian Jira
(v8.20.10#820010)