You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2013/09/30 23:36:26 UTC

[jira] [Issue Comment Deleted] (HBASE-9576) Fixups in hbase protobuf

     [ https://issues.apache.org/jira/browse/HBASE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-9576:
-------------------------

    Comment: was deleted

(was: Revert from 0.96.)

> Fixups in hbase protobuf
> ------------------------
>
>                 Key: HBASE-9576
>                 URL: https://issues.apache.org/jira/browse/HBASE-9576
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>            Reporter: stack
>         Attachments: 0001-HBASE-9576-task1.patch, 9612revert096.txt
>
>
> Benoit was looking at out pbs.  Had following remarks:
> {code}
> ...there is something that doesn't make sense to me...a MutateRequest can have a Condition...the Condition has row/family/qualifier...so for a single KV CAS, one needs to specify the...row/family/qualifier twice...once in the MutationProto and once in the Condition...not a huge deal...just weird
> ...also in Comparator.proto, both BinaryComparator and BinaryPrefixComparator (and BitComparator too actually) would have been better off without ByteArrayComparable, which seems a useless pb, but no big deal either
> {code}
> Will keep this issue open as place to accumulate pb fixups.



--
This message was sent by Atlassian JIRA
(v6.1#6144)