You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/07/28 15:20:34 UTC
[kudu-CR] KUDU-2817: Upgrade boost to 1.73.0
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16247
Change subject: KUDU-2817: Upgrade boost to 1.73.0
......................................................................
KUDU-2817: Upgrade boost to 1.73.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.73.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
M thirdparty/vars.sh
3 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16247/1
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2817: Upgrade boost to 1.73.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16247
to look at the new patch set (#2).
Change subject: KUDU-2817: Upgrade boost to 1.73.0
......................................................................
KUDU-2817: Upgrade boost to 1.73.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.73.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
---
M src/kudu/experiments/rwlock-perf.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
M thirdparty/vars.sh
4 files changed, 3 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16247/2
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
KUDU-2817: Upgrade boost to 1.74.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.74.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Reviewed-on: http://gerrit.cloudera.org:8080/16247
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/ubsan-blacklist.txt
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/rebalance/rebalance_algo.cc
M src/kudu/tserver/tablet_service.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
D thirdparty/patches/boost-issue-440-darwin-version.patch
M thirdparty/vars.sh
14 files changed, 60 insertions(+), 91 deletions(-)
Approvals:
Alexey Serbin: Verified
Bankim Bhavsar: Looks good to me, but someone else must approve
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#5) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
KUDU-2817: Upgrade boost to 1.74.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.74.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
---
M build-support/ubsan-blacklist.txt
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/rebalance/rebalance_algo.cc
M src/kudu/tserver/tablet_service.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
D thirdparty/patches/boost-issue-440-darwin-version.patch
M thirdparty/vars.sh
14 files changed, 60 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16247/5
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
KUDU-2817: Upgrade boost to 1.74.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.74.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
---
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/rebalance/rebalance_algo.cc
M src/kudu/tserver/tablet_service.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
M thirdparty/vars.sh
12 files changed, 58 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16247/3
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16247/5/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/16247/5/src/kudu/master/catalog_manager.cc@2142
PS5, Line 2142: optional<const string&> user;
: if (rpc) {
: user = rpc->remote_user().username();
: }
> Curious why not ternary operator for non-const optional variable as well?
Because it didn't work elegantly with boost::none out of the box for an optional that is bound to a reference. With new boost, they started prohibiting some implicit operations which could lead to subtle bugs. I didn't try to dance around that, just found this approach works as needed.
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Sep 2020 19:52:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade boost to 1.73.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.73.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16247/1//COMMIT_MSG
Commit Message:
PS1:
> boost::detail::spinlock has changed, so now there is a compilation error in
Thanks I was working on this but couldn't reproduce given I am on OSX. I will push this and see.
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 28 Jul 2020 18:07:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Sep 2020 19:55:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Patch Set 5: Verified+1
Unrelated test failure in ClientTest.TestFailedDnsResolution. See https://issues.apache.org/jira/browse/KUDU-1466 and https://issues.apache.org/jira/browse/KUDU-1552
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:14:22 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
KUDU-2817: Upgrade boost to 1.74.0
We are currently on boost 1.61.0 which is from 2016. This patch
upgrades to 1.74.0, the latest version.
Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
---
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/rebalance/rebalance_algo.cc
M src/kudu/tserver/tablet_service.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch
D thirdparty/patches/boost-issue-440-darwin-version.patch
M thirdparty/vars.sh
13 files changed, 58 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/16247/4
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2817: Upgrade boost to 1.73.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.73.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16247/1//COMMIT_MSG
Commit Message:
PS1:
boost::detail::spinlock has changed, so now there is a compilation error in src/kudu/experiments/rwlock-perf.cc:
08:32:41 /home/jenkins-slave/workspace/kudu-master/1/src/kudu/experiments/rwlock-perf.cc:50:8: error: overload resolution selected deleted operator '='
08:32:41 v_ = 0;
08:32:41 ~~ ^ ~
08:32:41 /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/atomic:2303:18: note: candidate function has been explicitly deleted
08:32:41 atomic_flag& operator=(const atomic_flag&) = delete;
08:32:41 ^
08:32:41 /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/atomic:2304:18: note: candidate function has been explicitly deleted
08:32:41 atomic_flag& operator=(const atomic_flag&) volatile = delete;
08:32:41 ^
08:32:41 1 error generated.
I guess the issue is that with version 1.73 boost uses std::atomic_flag for boost::detail::spinlock::v_, i.e. it's because of the following change:
--- spinlock.hpp 2016-05-05 14:14:22.000000000 -0700
+++ /tmp/boost/boost_1_73_0/boost/smart_ptr/detail/spinlock.hpp 2020-04-22 06:35:58.000000000 -0700
@@ -43,6 +43,9 @@
#elif defined( BOOST_SP_USE_PTHREADS )
# include <boost/smart_ptr/detail/spinlock_pt.hpp>
+#elif !defined( BOOST_NO_CXX11_HDR_ATOMIC )
+# include <boost/smart_ptr/detail/spinlock_std_atomic.hpp>
+
#elif defined(__GNUC__) && defined( __arm__ ) && !defined( __thumb__ )
# include <boost/smart_ptr/detail/spinlock_gcc_arm.hpp>
---
Probably, this will fix the issue:
diff --git a/src/kudu/experiments/rwlock-perf.cc b/src/kudu/experiments/rwlock-perf.cc
index 29ca01f0e..c2d4772ba 100644
--- a/src/kudu/experiments/rwlock-perf.cc
+++ b/src/kudu/experiments/rwlock-perf.cc
@@ -44,15 +44,7 @@ DEFINE_int32(num_threads, 8, "Number of threads to test");
using std::thread;
using std::vector;
-class my_spinlock : public boost::detail::spinlock {
- public:
- my_spinlock() {
- v_ = 0;
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(my_spinlock);
-};
+typedef boost::detail::spinlock my_spinlock;
struct PerCpuLock {
struct PaddedLock {
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 28 Jul 2020 16:18:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16247/5/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/16247/5/src/kudu/master/catalog_manager.cc@2142
PS5, Line 2142: optional<const string&> user;
: if (rpc) {
: user = rpc->remote_user().username();
: }
Curious why not ternary operator for non-const optional variable as well?
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:30:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2817: Upgrade boost to 1.74.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16247 )
Change subject: KUDU-2817: Upgrade boost to 1.74.0
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68241d782adc7abd66b2cdef2b6408f434a4eff0
Gerrit-Change-Number: 16247
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Sep 2020 14:10:05 +0000
Gerrit-HasComments: No