You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2018/10/08 20:01:47 UTC

[mesos] branch master updated: Updated verify-reviews.py to use current interpreter in subprocesses.

This is an automated email from the ASF dual-hosted git repository.

vinodkone pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 568fcdf  Updated verify-reviews.py to use current interpreter in subprocesses.
568fcdf is described below

commit 568fcdfd29788d9df89a51ffae7969c2bf0ea173
Author: Armand Grillet <ag...@mesosphere.io>
AuthorDate: Mon Oct 8 15:01:28 2018 -0500

    Updated verify-reviews.py to use current interpreter in subprocesses.
    
    This changes the command used in `support/verify-reviews.py` when
    running `support/apply-reviews.py` as a subprocess. It was previously
    `"python"`, which is generally Python 2, and is now `sys.executable`.
    
    That way, if verify-reviews.py is run with Python 3 (as it should),
    apply-reviews.py will be run with the same Python 3 interpreter. This
    should fix the `ImportError` issues we have recently seen in our CI.
    
    Review: https://reviews.apache.org/r/68951/
---
 support/verify-reviews.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/verify-reviews.py b/support/verify-reviews.py
index 56321ae..552dc36 100755
--- a/support/verify-reviews.py
+++ b/support/verify-reviews.py
@@ -94,7 +94,7 @@ def shell(command):
 def apply_review(review_id):
     """Apply a review using the script apply-reviews.py."""
     print("Applying review %s" % review_id)
-    shell("python support/apply-reviews.py -n -r %s" % review_id)
+    shell("%s support/apply-reviews.py -n -r %s" % (sys.executable, review_id))
 
 
 def apply_reviews(review_request, reviews, handler):