You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/03/13 16:21:57 UTC
Re: Review Request 31986: Container ID is sent on each TaskStatus
message back to the framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/
-----------------------------------------------------------
(Updated March 13, 2015, 4:21 p.m.)
Review request for mesos, Bernd Mathiske, Isabel Jimenez, Joerg Schad, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-2191
https://issues.apache.org/jira/browse/MESOS-2191
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8
src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b
src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8
src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
Diff: https://reviews.apache.org/r/31986/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 31986: Container ID is sent on each TaskStatus
message back to the framework.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review76393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31985, 31986]
All tests passed.
- Mesos ReviewBot
On March 13, 2015, 3:21 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31986/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 3:21 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Isabel Jimenez, Joerg Schad, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-2191
> https://issues.apache.org/jira/browse/MESOS-2191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8
> src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b
> src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8
> src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
>
> Diff: https://reviews.apache.org/r/31986/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31986: Container ID is sent on each TaskStatus
message back to the framework.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review77159
-----------------------------------------------------------
LGTM
- Bernd Mathiske
On March 13, 2015, 8:21 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31986/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 8:21 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Isabel Jimenez, Joerg Schad, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-2191
> https://issues.apache.org/jira/browse/MESOS-2191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8
> src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b
> src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8
> src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
>
> Diff: https://reviews.apache.org/r/31986/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 31986: Container ID is sent on each TaskStatus
message back to the framework.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review76643
-----------------------------------------------------------
LGTM
- Isabel Jimenez
On March 13, 2015, 3:21 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31986/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 3:21 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Isabel Jimenez, Joerg Schad, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-2191
> https://issues.apache.org/jira/browse/MESOS-2191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8
> src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b
> src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8
> src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
>
> Diff: https://reviews.apache.org/r/31986/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>