You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/03 00:14:08 UTC
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 11:14 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118256
-----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 917)
<https://reviews.apache.org/r/42782/#comment179477>
s/uint32_t/uint16_t/
src/tests/containerizer/isolator_tests.cpp (line 998)
<https://reviews.apache.org/r/42782/#comment179478>
I would just check if the primiary is the one we set. For secondary, I would just check that it's not 0.
- Jie Yu
On Feb. 8, 2016, 6:43 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 6:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit-test to test net_cls major handles set from command line.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
>
> Diff: https://reviews.apache.org/r/42782/diff/
>
>
> Testing
> -------
>
> make and make check.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42782: Added a unit-test to test net_cls primary
handles set from command line.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118292
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 7:13 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit-test to test net_cls primary handles set from command line.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
>
> Diff: https://reviews.apache.org/r/42782/diff/
>
>
> Testing
> -------
>
> make and make check.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42782: Added a unit-test to test net_cls primary
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:05 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
removing cyclical dependency.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls primary handles set from command line.
Diffs
-----
src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls primary
handles set from command line.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118291
-----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 1000)
<https://reviews.apache.org/r/42782/#comment179517>
I would use EXPECT_NE(0, classid.get() & 0xffff);
- Jie Yu
On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 7:13 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit-test to test net_cls primary handles set from command line.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
>
> Diff: https://reviews.apache.org/r/42782/diff/
>
>
> Testing
> -------
>
> make and make check.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42782: Added a unit-test to test net_cls primary
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 7:13 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added a unit-test to test net_cls primary handles set from command line.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description (updated)
-------
Added a unit-test to test net_cls primary handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 6:43 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:27 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42982, 42983, 43096, 42618, 42780, 42781, 43107, 42782]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 3:34 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:34 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit-test to test net_cls major handles set from command line.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 67322abc776cbd501385932676852a79b74ef248
>
> Diff: https://reviews.apache.org/r/42782/diff/
>
>
> Testing
> -------
>
> make and make check.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:34 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 67322abc776cbd501385932676852a79b74ef248
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 4:42 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan
Re: Review Request 42782: Added a unit-test to test net_cls major
handles set from command line.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 12:54 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344
Repository: mesos
Description
-------
Added a unit-test to test net_cls major handles set from command line.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029
Diff: https://reviews.apache.org/r/42782/diff/
Testing
-------
make and make check.
Thanks,
Avinash sridharan