You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 00:05:50 UTC

[GitHub] [pulsar] mattisonchao commented on a change in pull request #9970: [Schema] Fix autoConsumeSchema deadLetter problem.

mattisonchao commented on a change in pull request #9970:
URL: https://github.com/apache/pulsar/pull/9970#discussion_r816346949



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1691,12 +1692,12 @@ protected void completeOpBatchReceive(OpBatchReceive<T> op) {
             initDeadLetterProducerIfNeeded();
             List<MessageImpl<T>> finalDeadLetterMessages = deadLetterMessages;
             MessageIdImpl finalMessageId = messageId;
-            deadLetterProducer.thenAccept(producerDLQ -> {
+            deadLetterProducer.thenAcceptAsync(producerDLQ -> {

Review comment:
       Why do we use a common pool to run the next logic?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org