You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "tbonelee (via GitHub)" <gi...@apache.org> on 2026/05/30 08:49:54 UTC

[PR] [ZEPPELIN-6423] Reload note when switching notebooks in the Angular UI [zeppelin]

tbonelee opened a new pull request, #5259:
URL: https://github.com/apache/zeppelin/pull/5259

   ### What is this PR for?
   Navigating between notes in the Angular UI changed the URL but left the page showing the previously opened note.
   
   The note fetch in `NotebookComponent` was bound only to the WebSocket `connectedStatus$` stream (introduced in ZEPPELIN-6387). Because Angular reuses `NotebookComponent` across `:noteId` route changes — so `ngOnInit` does not re-run — and the WebSocket stays connected, selecting another note from the header notebook list never re-fetched the note. The URL/route params updated, but `getNote()` was never called for the new `noteId`, so the page kept rendering the old note.
   
   This PR drives the fetch from a `combineLatest` of the connection status and the route params, so it fires on **both** a WebSocket (re)connect **and** a `noteId`/`revisionId` change. The reconnect-reload behavior from ZEPPELIN-6387 is preserved; `distinctUntilChanged` on the connection stream avoids a redundant fetch on init.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] Re-fetch the note on `noteId`/`revisionId` route changes
   * [x] Preserve WebSocket reconnect-reload behavior
   * [x] Add e2e regression test
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-6423
   
   ### How should this be tested?
   * **Automated:** `zeppelin-web-angular/e2e/tests/notebook/main/notebook-navigation.spec.ts` opens one note, then navigates to a second note via the header "Notebook" dropdown and asserts the displayed note title (not just the URL) updates. Verified failing before the fix and passing after, against a live backend.
   * **Manual:**
     1. Open a notebook.
     2. From the header **Notebook** dropdown, click a different note.
     3. The page content should switch to the newly selected note (previously it stayed on the old note while the URL changed).
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6423] Reload note when switching notebooks in the Angular UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5259:
URL: https://github.com/apache/zeppelin/pull/5259#issuecomment-4604314241

   Merged into master and branch-0.12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6423] Reload note when switching notebooks in the Angular UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5259:
URL: https://github.com/apache/zeppelin/pull/5259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6423] Reload note when switching notebooks in the Angular UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5259:
URL: https://github.com/apache/zeppelin/pull/5259#issuecomment-4591255189

   @tbonelee Could you please rebase it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org