[GitHub] [airflow] houqp commented on a change in pull request #8545: [AIRFLOW-249] Refactor the SLA mechanism (Continuation from #3584 )

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #8545:
URL: https://github.com/apache/airflow/pull/8545#discussion_r417532128



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -750,7 +600,16 @@ def _process_dags(self, dags: List[DAG], session=None):
             if dag_runs_for_dag:
                 tis_out.extend(self._process_task_instances(dag, dag_runs_for_dag))
                 if check_slas:
-                    self.manage_slas(dag)
+                    # Look for SLA misses for all task instances associated with this
+                    # DAG, whether or not corresponding runs have been created yet.
+                    # Catch exceptions, though; we don't want SLA checking failures to
+                    # prevent tasks from being scheduled!
+                    try:
+                        dag.manage_slas()
+                    except Exception:  # pylint: disable=broad-except

Review comment:
       since we will be using sla for critical monitoring, i think we should do more than just log the exception. how about adding a metric for this so one can setup alerting for issues that impacts sla monitoring?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org