You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/12/15 18:47:44 UTC

Re: [PR] fix: Revert "fix(sqllab): flaky json explore modal due to over-rendering (#26156)" [superset]

codecov[bot] commented on PR #26284:
URL: https://github.com/apache/superset/pull/26284#issuecomment-1858340511

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `9 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`38f5e4d`)](https://app.codecov.io/gh/apache/superset/commit/38f5e4d490b1c3bc315d3695972541cec033bd87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`3669568`)](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18%.
   
   | [Files](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...frontend/src/SqlLab/components/SouthPane/index.tsx](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9pbmRleC50c3g=) | 75.75% | [3 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ntend/src/SqlLab/components/QueryHistory/index.tsx](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS9pbmRleC50c3g=) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26284      +/-   ##
   ==========================================
   - Coverage   69.18%   69.18%   -0.01%     
   ==========================================
     Files        1946     1945       -1     
     Lines       75969    75968       -1     
     Branches     8469     8467       -2     
   ==========================================
   - Hits        52561    52558       -3     
   - Misses      21222    21223       +1     
   - Partials     2186     2187       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/26284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/26284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.51% <76.92%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26284?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org