You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2015/11/20 01:02:18 UTC

Review Request 40510: Remove unused and deprecated code from commons.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/
-----------------------------------------------------------

Review request for Aurora, John Sirois and Bill Farner.


Repository: aurora


Description
-------

Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.


Diffs
-----

  commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
  commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 

Diff: https://reviews.apache.org/r/40510/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Zameer Manji


Re: Review Request 40510: Remove unused and deprecated code from commons.

Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/#review107357
-----------------------------------------------------------

Ship it!


Ship It!

- John Sirois


On Nov. 19, 2015, 5:25 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40510/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5:25 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
>   commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
>   commons/src/main/java/org/apache/aurora/common/thrift/Util.java 7802614e050f0fa6fc5ad94fd738433f7f75abab 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java a032aa35d6d7772cd5c0d8d9a45f9edc20e47778 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 
> 
> Diff: https://reviews.apache.org/r/40510/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 40510: Remove unused and deprecated code from commons.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/#review107379
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Nov. 19, 2015, 4:25 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40510/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 4:25 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
>   commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
>   commons/src/main/java/org/apache/aurora/common/thrift/Util.java 7802614e050f0fa6fc5ad94fd738433f7f75abab 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java a032aa35d6d7772cd5c0d8d9a45f9edc20e47778 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 
> 
> Diff: https://reviews.apache.org/r/40510/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 40510: Remove unused and deprecated code from commons.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/#review107282
-----------------------------------------------------------

Ship it!


Master (c9a7172) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 20, 2015, 12:25 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40510/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 12:25 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
>   commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
>   commons/src/main/java/org/apache/aurora/common/thrift/Util.java 7802614e050f0fa6fc5ad94fd738433f7f75abab 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java a032aa35d6d7772cd5c0d8d9a45f9edc20e47778 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 
> 
> Diff: https://reviews.apache.org/r/40510/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 40510: Remove unused and deprecated code from commons.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 4:25 p.m.)


Review request for Aurora, John Sirois and Bill Farner.


Changes
-------

last batch


Repository: aurora


Description
-------

Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.


Diffs (updated)
-----

  commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
  commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
  commons/src/main/java/org/apache/aurora/common/thrift/Util.java 7802614e050f0fa6fc5ad94fd738433f7f75abab 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
  commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java a032aa35d6d7772cd5c0d8d9a45f9edc20e47778 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 

Diff: https://reviews.apache.org/r/40510/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Zameer Manji


Re: Review Request 40510: Remove unused and deprecated code from commons.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 4:13 p.m.)


Review request for Aurora, John Sirois and Bill Farner.


Changes
-------

Another batch.


Repository: aurora


Description
-------

Remove unused and deprecated code from commons. This is some code I deleted previously but neglected to put up for review until now.


Diffs (updated)
-----

  commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java 7e88b27f2d4c210a1f6b04f256452ffbd3639be8 
  commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java 93f6610f24b0f19bac4d8c4daad44b8aadce85b8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java fb578e191c0349312e065cafcc0b82fefc870ba8 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 07ae3834ff07350110c5b627d29cd4ec2a623aa0 
  commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 110c9ef82e445d47866ffa604fa84d37755f0c3f 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 377dbfda85a1e1e47e3855b9dcdf538ffb843e54 

Diff: https://reviews.apache.org/r/40510/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Zameer Manji