You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "taskain7 (via GitHub)" <gi...@apache.org> on 2023/05/11 07:39:56 UTC
[GitHub] [fineract] taskain7 opened a new pull request, #3170: [FINERACT-1906] Add disbursement charge to accrual transactions
taskain7 opened a new pull request, #3170:
URL: https://github.com/apache/fineract/pull/3170
## Description
Fineract creates an accrual transaction, when a disbursement fee is charged.
## Test
`ClientLoanIntegrationTest:loanWithChargesOfTypeAmountPercentageAndPeriodicAccrualAccountingEnabled()` existing test case covers the integration test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3170: [FINERACT-1906] Add disbursement charge to accrual transactions
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3170:
URL: https://github.com/apache/fineract/pull/3170#discussion_r1196573857
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -484,6 +486,15 @@ public CommandProcessingResult disburseLoan(final Long loanId, final JsonCommand
&& loanCharge.isChargePending()) {
disBuLoanCharges.put(loanCharge.getId(), loanCharge.amountOutstanding());
}
+ if (loanCharge.isDisbursementCharge()) {
Review Comment:
@taskain7 Agree on this. Why do it need to be native query?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] mohitsinha commented on a diff in pull request #3170: [FINERACT-1906] Add disbursement charge to accrual transactions
Posted by "mohitsinha (via GitHub)" <gi...@apache.org>.
mohitsinha commented on code in PR #3170:
URL: https://github.com/apache/fineract/pull/3170#discussion_r1193122135
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -484,6 +486,15 @@ public CommandProcessingResult disburseLoan(final Long loanId, final JsonCommand
&& loanCharge.isChargePending()) {
disBuLoanCharges.put(loanCharge.getId(), loanCharge.amountOutstanding());
}
+ if (loanCharge.isDisbursementCharge()) {
Review Comment:
Looks good.
But can this be handled using JPA rather than Raw queries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] taskain7 merged pull request #3170: [FINERACT-1906] Add disbursement charge to accrual transactions
Posted by "taskain7 (via GitHub)" <gi...@apache.org>.
taskain7 merged PR #3170:
URL: https://github.com/apache/fineract/pull/3170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org