You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2023/08/30 20:38:00 UTC
[jira] [Comment Edited] (CASSANDRA-18803) Refactor validation logic in StorageService.rebuild
[ https://issues.apache.org/jira/browse/CASSANDRA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760619#comment-17760619 ]
Stefan Miklosovic edited comment on CASSANDRA-18803 at 8/30/23 8:37 PM:
------------------------------------------------------------------------
[3.0|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3035/workflows/7f55fcda-1cf0-43db-8471-ebd54be87c9e]
[3.11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3034/workflows/e10a709e-97e1-4795-b4ca-7e3aac3253cd]
[4.0 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3033/workflows/f2e2c30f-6d37-48cc-874a-104f34f67b50]
[4.0 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3033/workflows/af8cc33a-69ca-4164-800f-3b049a8ac6da]
[4.1 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3036/workflows/5297fd1a-f33b-4a17-b56d-d0522b65c95b]
[4.1 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3036/workflows/5626cfef-a6a7-453c-9abf-43c30678ec41]
[5.0 j17|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3037/workflows/70cf2550-e278-426a-a63b-533c25c4eccf]
[5.0 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3037/workflows/2a5dcdc5-17f9-4311-9aeb-60fcea5787d9]
These builds are technically not same as what is in the current branches. I just moved one check outside of try-catch to add it logically where it belongs (where other checks are) and I moved logging into try catch (was outside of it).
was (Author: smiklosovic):
[3.0|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3035/workflows/7f55fcda-1cf0-43db-8471-ebd54be87c9e]
[3.11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3034/workflows/e10a709e-97e1-4795-b4ca-7e3aac3253cd]
[4.0 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3033/workflows/f2e2c30f-6d37-48cc-874a-104f34f67b50]
[4.0 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3033/workflows/af8cc33a-69ca-4164-800f-3b049a8ac6da]
[4.1 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3036/workflows/5297fd1a-f33b-4a17-b56d-d0522b65c95b]
[4.1 j8|[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3036/workflows/5626cfef-a6a7-453c-9abf-43c30678ec41]
[5.0 j17|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3037/workflows/70cf2550-e278-426a-a63b-533c25c4eccf]
[5.0 j11|[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3037/workflows/2a5dcdc5-17f9-4311-9aeb-60fcea5787d9]
These builds are technically not same as what is in the current branches. I just moved one check outside of try-catch to add it logically where it belongs (where other checks are) and I moved logging into try catch (was outside of it).
> Refactor validation logic in StorageService.rebuild
> ---------------------------------------------------
>
> Key: CASSANDRA-18803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18803
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is a follow-up ticket of CASSANDRA-14319
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org