You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/03 15:41:39 UTC
[PR] [DRAFT] try to test with slf4jv2 [incubator-pekko-connectors]
pjfanning opened a new pull request, #539:
URL: https://github.com/apache/incubator-pekko-connectors/pull/539
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566924476
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
Thanks for the input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566807852
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
it isn't a compile problem - that run is from experimental changes I made. The tests fail due to log capture not working but you can get the tests to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566619183
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
Who is dependent on Slf4J v1? Seems like slf4j2 is backward compatible. https://www.slf4j.org/faq.html#compatibility
Should we remove logback 1.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566803837
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
I see, I found those failed tests and commented on them here as an investigation entrance:
- https://github.com/apache/pekko-connectors/actions/runs/8690073541/job/23829155899
- https://github.com/apache/pekko-connectors/actions/runs/8690073541/job/23829160005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with slf4jv2 [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566782947
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
The tests for solar and kudu fail if we force them to use latest slf4j and logback. People are welcome to try to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org