You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2014/05/01 15:52:36 UTC

Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/
-----------------------------------------------------------

Review request for Ambari, Tom Beerbower and Yusaku Sako.


Bugs: AMBARI-5617
    https://issues.apache.org/jira/browse/AMBARI-5617


Repository: ambari


Description
-------

The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.


Diffs
-----

  contrib/views/files/pom.xml PRE-CREATION 
  contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
  contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
  contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
  contrib/views/files/src/main/resources/view.xml PRE-CREATION 
  contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
  contrib/views/pom.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/20948/diff/


Testing
-------

The code submission includes unit tests which all execute successfully.


Thanks,

Erik Bergenholtz

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.


> On May 2, 2014, 4:32 a.m., Yusaku Sako wrote:
> > Reviewed the frontend code.
> > Looks good.
> > Please upload all the binary artifacts to https://issues.apache.org/jira/browse/AMBARI-5617.

Actually, rat check fails.
Please run "mvn apache-rat:check" to make sure it passes (for .json and .svg, add to the exclusion list).
I saw errors for the following files.  
  src/assembly/assembly.xml
  src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg
  src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg
  src/main/resources/ui/bin
  src/main/resources/ui/bower.json
  src/main/resources/ui/generators/collection/generator.json
  src/main/resources/ui/generators/controller/generator.json
  src/main/resources/ui/generators/model/generator.json
  src/main/resources/ui/generators/route/generator.json
  src/main/resources/ui/generators/template/generator.json
  src/main/resources/ui/generators/view/generator.json
  src/main/resources/ui/package.json
  src/main/resources/ui/test/spec.coffee


- Yusaku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42007
-----------------------------------------------------------


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42007
-----------------------------------------------------------


Reviewed the frontend code.
Looks good.
Please upload all the binary artifacts to https://issues.apache.org/jira/browse/AMBARI-5617.

- Yusaku Sako


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review41992
-----------------------------------------------------------


We need to make sure that all files match the coding conventions for Ambari ...

https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari.

Also, make sure that all files have appropriate Apache header. 



- Tom Beerbower


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.


> On May 2, 2014, 10:42 p.m., Yusaku Sako wrote:
> > License header needs to be added for:
> > contrib/views/files/src/assembly/assembly.xml
> > contrib/views/files/src/main/resources/ui/test/spec.coffee
> >

Just to clarify, the top-level pom.xml has been modified to take care of .json and .svg, so these files pass the rat check fine now.


- Yusaku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42073
-----------------------------------------------------------


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42073
-----------------------------------------------------------


License header needs to be added for:
contrib/views/files/src/assembly/assembly.xml
contrib/views/files/src/main/resources/ui/test/spec.coffee


- Yusaku Sako


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review41968
-----------------------------------------------------------



contrib/views/files/src/assembly/assembly.xml
<https://reviews.apache.org/r/20948/#comment75642>

    Missing header ...
    
    <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
    
           http://www.apache.org/licenses/LICENSE-2.0
    
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
    -->


- Tom Beerbower


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.


> On May 1, 2014, 10:55 p.m., Tom Beerbower wrote:
> > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg, lines 1-2
> > <https://reviews.apache.org/r/20948/diff/1/?file=572605#file572605line1>
> >
> >     Do we need an Apache header here?

This is an external file that is under MIT license.
We don't need Apache header here.


- Yusaku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review41969
-----------------------------------------------------------


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review41969
-----------------------------------------------------------



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
<https://reviews.apache.org/r/20948/#comment75643>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
<https://reviews.apache.org/r/20948/#comment75644>

    Can we remove dead code?



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java
<https://reviews.apache.org/r/20948/#comment75645>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java
<https://reviews.apache.org/r/20948/#comment75646>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java
<https://reviews.apache.org/r/20948/#comment75647>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java
<https://reviews.apache.org/r/20948/#comment75649>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java
<https://reviews.apache.org/r/20948/#comment75650>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java
<https://reviews.apache.org/r/20948/#comment75651>

    Class and public methods in this file should be documented.



contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg
<https://reviews.apache.org/r/20948/#comment75652>

    Do we need an Apache header here?


- Tom Beerbower


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42077
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/#review42006
-----------------------------------------------------------


Reviewed the frontend code.
Looks good.
Please upload all the binary artifacts to https://issues.apache.org/jira/browse/AMBARI-5617.

- Yusaku Sako


On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20948/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:52 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5617
>     https://issues.apache.org/jira/browse/AMBARI-5617
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/pom.xml PRE-CREATION 
>   contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
>   contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
>   contrib/views/files/src/main/resources/view.xml PRE-CREATION 
>   contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
>   contrib/views/pom.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20948/diff/
> 
> 
> Testing
> -------
> 
> The code submission includes unit tests which all execute successfully.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>

Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end

Posted by Erik Bergenholtz <eb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20948/
-----------------------------------------------------------

(Updated May 1, 2014, 1:52 p.m.)


Review request for Ambari, Tom Beerbower and Yusaku Sako.


Bugs: AMBARI-5617
    https://issues.apache.org/jira/browse/AMBARI-5617


Repository: ambari


Description
-------

The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS.


Diffs
-----

  contrib/views/files/pom.xml PRE-CREATION 
  contrib/views/files/src/assembly/assembly.xml PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION 
  contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION 
  contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/bin PRE-CREATION 
  contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/package.json PRE-CREATION 
  contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION 
  contrib/views/files/src/main/resources/view.xml PRE-CREATION 
  contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION 
  contrib/views/pom.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/20948/diff/


Testing
-------

The code submission includes unit tests which all execute successfully.


Thanks,

Erik Bergenholtz