You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/27 00:22:03 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #43121: [SPARK-45335][SQL][DOCS] Correct the group of `ElementAt` and `TryElementAt`

zhengruifeng commented on code in PR #43121:
URL: https://github.com/apache/spark/pull/43121#discussion_r1337896202


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -2333,7 +2333,7 @@ case class Get(
        b
   """,
   since = "2.4.0",
-  group = "map_funcs")
+  group = "collection_funcs")

Review Comment:
   I don't think it means `collection_funcs` is forbidden.
   
   `Concat` works with multiple types, including string, binary and array, so it's not just an array function;
   
   As I mentioned above, it looks like a `collection function` supports collection type (map/array/struct/etc) and some other types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org