[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

[GitBox <gi...@apache.org>]

slfan1989 commented on code in PR #4938:
URL: https://github.com/apache/hadoop/pull/4938#discussion_r988627305


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterMetrics.java:
##########
@@ -342,6 +378,34 @@ private RouterMetrics() {
     listReservationLatency =
         registry.newQuantiles("listReservationLatency",
             "latency of list reservation timeouts", "ops", "latency", 10);
+
+    getAppActivitiesLatency =
+        registry.newQuantiles("getAppActivitiesLatency",
+            "latency of get app activities timeouts", "ops", "latency", 10);
+
+    getAppStatisticsLatency =
+        registry.newQuantiles("getAppStatisticsLatency",
+            "latency of get app statistics timeouts", "ops", "latency", 10);
+
+    getAppPriorityLatency =
+        registry.newQuantiles("getAppPriorityLatency",
+            "latency of get app priority timeouts", "ops", "latency", 10);
+
+    getAppQueueLatency =
+        registry.newQuantiles("getAppQueueLatency",
+            "latency of get app queue timeouts", "ops", "latency", 10);
+
+    getUpdateQueueLatency =
+        registry.newQuantiles("getUpdateQueueLatency",
+            "latency of update app queue timeouts", "ops", "latency", 10);
+
+    getAppTimeoutLatency =
+        registry.newQuantiles("getAppTimeoutLatency",
+            "latency of get apptimeout timeouts", "ops", "latency", 10);
+
+    getAppTimeoutsLatency =

Review Comment:
   Thanks for your suggestion, I will fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org