[PR] Improved: Upgrade Gradle to 9.8.2 and CodeNarc to 4.0.0 (OFBIZ-13208) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2411:
URL: https://github.com/apache/ofbiz-framework/pull/2411

   - Bump the Gradle wrapper from 8.14.6 to 9.8.2 and regenerate gradlew and gradlew.bat with the 9.8.2 wrapper task.
   - Import groovy.xml.XmlParser in build.gradle and common.gradle, since Gradle 9 embeds Groovy 4, which no longer provides groovy.util.XmlParser.
   - Run external processes from task actions through an injected ExecOperations (terminateOfbiz, gitInfoFooter, generateDBPassword, generateEncryptedSecret, reEncryptAllSecrets and pullPlugin), since Gradle 9 removed Project.exec and Project.javaexec.
   - Read git output at configuration time through providers.exec instead of String.execute(), which Gradle 9.8 deprecates at configuration time.
   - Collect the cleanAll dependencies from tasks.names, since DomainObjectCollection.findAll(Closure) is deprecated.
   - Bump CodeNarc from 3.7.0-groovy-4.0 to 4.0.0, which is built on Groovy 5 and runs on Java 17. The plain version also lets Dependabot propose future CodeNarc updates, which it skipped while the current version carried the -groovy-4.0 suffix.
   
   The Java source and target compatibility stay at 17. This supersedes #2401, which only bumps the wrapper and fails on the XmlParser import.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Upgrade Gradle to 9.8.2 and CodeNarc to 4.0.0 (OFBIZ-13208) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2411:
URL: https://github.com/apache/ofbiz-framework/pull/2411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Upgrade Gradle to 9.8.2 and CodeNarc to 4.0.0 (OFBIZ-13208) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak commented on PR #2411:
URL: https://github.com/apache/ofbiz-framework/pull/2411#issuecomment-6362258676

   Thanks for the review @jacopoc, I have created OFBIZ-13720 and OFBIZ-13721 for the suggested followups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org