You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2012/09/05 17:58:07 UTC
[jira] [Created] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Tom White created MAPREDUCE-4637:
------------------------------------
Summary: Killing an unassigned task attempt causes the job to fail
Key: MAPREDUCE-4637
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Affects Versions: 2.0.0-alpha
Reporter: Tom White
Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480584#comment-13480584 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550118/MAPREDUCE-4637-trunk-v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app:
org.apache.hadoop.mapreduce.v2.app.TestMRClientService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2949//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2949//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk-v6.patch
Fixing Test.
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448845#comment-13448845 ]
Tom White commented on MAPREDUCE-4637:
--------------------------------------
Here are the relevant lines from the AM's log when a task attempt (attempt_1337372605417_0946_m_000095_0) was killed manually from the CLI:
{noformat}
2012-05-24 11:45:49,328 INFO [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl: attempt_1337372605417_0946_m_000095_0 TaskAttempt Transitioned from NEW to UNASSIGNED
2012-05-24 12:01:55,072 INFO [IPC Server handler 0 on 53369] org.apache.hadoop.mapreduce.v2.app.client.MRClientService: Kill task attempt received from client attempt_1337372605417_0946_m_000095_0
2012-05-24 12:01:55,073 ERROR [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl: Can't handle this event at current state for attempt_1337372605417_0946_m_000095_0
org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: TA_DIAGNOSTICS_UPDATE at UNASSIGNED
at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:301)
at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43)
at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443)
at org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl.handle(TaskAttemptImpl.java:941)
at org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl.handle(TaskAttemptImpl.java:133)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$TaskAttemptEventDispatcher.handle(MRAppMaster.java:912)
at org.apache.hadoop.mapreduce.v2.app.MRAppMaster$TaskAttemptEventDispatcher.handle(MRAppMaster.java:904)
at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:125)
at org.apache.hadoop.yarn.event.AsyncDispatcher$1.run(AsyncDispatcher.java:74)
at java.lang.Thread.run(Thread.java:662)
2012-05-24 12:01:55,076 INFO [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.TaskAttemptImpl: attempt_1337372605417_0946_m_000095_0 TaskAttempt Transitioned from UNASSIGNED to KILLED
2012-05-24 12:01:55,078 INFO [AsyncDispatcher event handler] org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl: job_1337372605417_0946Job Transitioned from RUNNING to ERROR
2012-05-24 12:01:55,078 INFO [Thread-46] org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator: Processing the event EventType: CONTAINER_DEALLOCATE
{noformat}
The bugs seems to be in MRClientService.MRClientProtocolHandler#killTaskAttempt() where the handler is sent a TaskAttemptDiagnosticsUpdateEvent. However, in the UNASSIGNED state a TaskAttempt cannot handle this event, so it fails with an error. The simplest fix would be to allow a TaskAttemptDiagnosticsUpdateEvent in the UNASSIGNED state. The same bug occurs with the fail task command.
This bug was found by Wing Yew Poon.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482696#comment-13482696 ]
Hudson commented on MAPREDUCE-4637:
-----------------------------------
Integrated in Hadoop-trunk-Commit #2917 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2917/])
MAPREDUCE-4637. Handle TaskAttempt diagnostic updates while in the NEW and UNASSIGNED states. (Contributed by Mayank Bansal) (Revision 1401474)
Result = SUCCESS
sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401474
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk-v3.patch
Based on Tom's suggestion extending patch for the new state as well.
Arun,
Did you get a chance to take a look?
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-4637:
---------------------------------
Attachment: MapReduce.png
Looking at the state transition diagrams (attached) it's possible to kill a job, task or task attempt in any of their pre-running states: NEW, INITED/SCHEDULED/(UN)ASSIGNED. I don't see a reason to change that since users may have a reason to kill a task attempt before it is running. The bug here is that the unassigned state of the task attempt does not have a TA_DIAGNOSTICS_UPDATE transition which causes the kill to fail.
I just noticed that job has a JOB_DIAGNOSTIC_UPDATE transition from both the NEW and INITED states, so perhaps we should extend the patch to add a TA_DIAGNOSTICS_UPDATE from the NEW state of task attempt too for completeness.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449559#comment-13449559 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544026/MapReduce.png
against trunk revision .
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2824//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449312#comment-13449312 ]
Arun C Murthy commented on MAPREDUCE-4637:
------------------------------------------
Another option is to validate that a kill is only sent to RUNNING task-attempts. That seems a better option, no?
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449946#comment-13449946 ]
Tom White commented on MAPREDUCE-4637:
--------------------------------------
BTW you can generate the state diagram by following the instructions in YARN's README.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483235#comment-13483235 ]
Hudson commented on MAPREDUCE-4637:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1235 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1235/])
MAPREDUCE-4637. Handle TaskAttempt diagnostic updates while in the NEW and UNASSIGNED states. (Contributed by Mayank Bansal) (Revision 1401474)
Result = SUCCESS
sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401474
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480666#comment-13480666 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550133/MAPREDUCE-4637-trunk-v6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2950//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2950//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449900#comment-13449900 ]
Mayank Bansal commented on MAPREDUCE-4637:
------------------------------------------
Thanks Tom for sending the state diagram. It is very helpful.
I think its a good idea for adding TA_DIAGNOSTICS_UPDATE from the NEW state.
Arun,
Do you think its reasonable?
I can add this state in this patch itself or you want me to open another jira for that?
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4637:
--------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
Release Note: Handle TaskAttempt diagnostic updates while in the NEW and UNASSIGNED states.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk and branch-2.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482807#comment-13482807 ]
Hudson commented on MAPREDUCE-4637:
-----------------------------------
Integrated in Hadoop-Yarn-trunk #13 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/13/])
MAPREDUCE-4637. Handle TaskAttempt diagnostic updates while in the NEW and UNASSIGNED states. (Contributed by Mayank Bansal) (Revision 1401474)
Result = FAILURE
sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401474
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4637:
--------------------------------------
Status: Open (was: Patch Available)
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk-v4.patch
Fixing the test.
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482681#comment-13482681 ]
Siddharth Seth commented on MAPREDUCE-4637:
-------------------------------------------
+1. Committing this. Thanks Mayank.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Status: Patch Available (was: Open)
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Attachments: MAPREDUCE-4637-trunk.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452431#comment-13452431 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544522/MAPREDUCE-4637-trunk-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app:
org.apache.hadoop.mapreduce.v2.app.TestMRClientService
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2837//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2837//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452605#comment-13452605 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544559/MAPREDUCE-4637-trunk-v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2840//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2840//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Status: Open (was: Patch Available)
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White reassigned MAPREDUCE-4637:
------------------------------------
Assignee: Mayank Bansal
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449144#comment-13449144 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543911/MAPREDUCE-4637-trunk-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2820//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2820//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449065#comment-13449065 ]
Hadoop QA commented on MAPREDUCE-4637:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543899/MAPREDUCE-4637-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2817//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2817//console
This message is automatically generated.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Attachments: MAPREDUCE-4637-trunk.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Status: Patch Available (was: Open)
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449460#comment-13449460 ]
Mayank Bansal commented on MAPREDUCE-4637:
------------------------------------------
I think we should kill all the tasks irrespective of whatever state they are in. Isn't it?
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449099#comment-13449099 ]
Tom White commented on MAPREDUCE-4637:
--------------------------------------
Thanks for the patch Mayank. It looks good to me, and when I ran the test without the fix it failed. The only thing I think needs changing is the method name for the test, which should be lowerCamelCase.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Attachments: MAPREDUCE-4637-trunk.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483190#comment-13483190 ]
Hudson commented on MAPREDUCE-4637:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1205 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1205/])
MAPREDUCE-4637. Handle TaskAttempt diagnostic updates while in the NEW and UNASSIGNED states. (Contributed by Mayank Bansal) (Revision 1401474)
Result = FAILURE
sseth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401474
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MAPREDUCE-4637-trunk-v6.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk-v2.patch
Thanks Tom for the review. I updated the patch with your comments.
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk-v5.patch
Thanks sid for the review, I updated the patch with your comments. I rebased the patch as well with the latest source.
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Attachment: MAPREDUCE-4637-trunk.patch
Attaching the patch.
Thanks,
Mayank
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Attachments: MAPREDUCE-4637-trunk.patch
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479682#comment-13479682 ]
Siddharth Seth commented on MAPREDUCE-4637:
-------------------------------------------
bq. I don't see a reason to change that since users may have a reason to kill a task attempt before it is running. The bug here is that the unassigned state of the task attempt does not have a TA_DIAGNOSTICS_UPDATE transition which causes the kill to fail.
A kill seems to be a valid operation before an attempt starts. At a later point, maybe we should include diagnostic messages along with the actual event instead of 2 independent events.
The patch needs some minor changes though. There's an extra Diagnostic Event being generated from TaskImpl - which isn't required. The unit tests may be mocking more than they should, but I don't see that as being an issue.
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4637) Killing an unassigned task
attempt causes the job to fail
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4637:
-------------------------------------
Status: Patch Available (was: Open)
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
> Key: MAPREDUCE-4637
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 2.0.0-alpha
> Reporter: Tom White
> Assignee: Mayank Bansal
> Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MAPREDUCE-4637-trunk-v5.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira