[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2436: [Improve][Connector-V2] Pulsar support user-defined schema

[GitBox <gi...@apache.org>]

hailin0 commented on code in PR #2436:
URL: https://github.com/apache/incubator-seatunnel/pull/2436#discussion_r950798921


##########
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/PulsarSource.java:
##########
@@ -222,7 +225,9 @@ private void setPartitionDiscoverer(Config config) {
 
     private void setDeserialization(Config config) {
         String format = config.getString("format");
-        // TODO: json format
+        // TODO: format SPI
+        SeaTunnelRowType rowType = SeatunnelSchema.buildWithConfig(config.getConfig(SeatunnelSchema.SCHEMA)).getSeaTunnelRowType();

Review Comment:
   Use `fields` as config key?  reference #2469
   
   example:
   ```java
   SeaTunnelRowType rowType = SeatunnelSchema.buildWithConfig(config).getSeaTunnelRowType();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org