You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2015/03/24 19:07:53 UTC
[GitHub] incubator-brooklyn pull request: Set the CAMP planId as an attribu...
GitHub user grkvlt opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/569
Set the CAMP planId as an attribute so that it is not inherited
Because the CAMP planId is a `ConfigKey` it is inherited, so attempts to resolve entities by ID will return all children. Sets the plan ID as an attribute only on the actual entity.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/incubator-brooklyn fix/camp-plan-id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #569
----
commit 927556fcb23936b418d22711c6d26c93b4dbc734
Author: Andrew Kennedy <gr...@apache.org>
Date: 2015-03-24T18:04:02Z
Set the CAMP planId as an attribute so that it is not inherited
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix the CAMP planId so that it is...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#issuecomment-85657345
OK, the last failure is just `java.lang.RuntimeException: unable to find a free port at or above 8080` so I'm happy to merge now :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix the CAMP planId so that it is...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#discussion_r27066283
--- Diff: utils/common/src/main/java/brooklyn/config/ConfigInheritance.java ---
@@ -18,9 +18,11 @@
*/
package brooklyn.config;
+import java.io.Serializable;
+
import com.google.common.annotations.Beta;
-public abstract class ConfigInheritance {
+public abstract class ConfigInheritance implements Serializable {
--- End diff --
I'll just ignore the warnings, since it's not needed for actual serialisation here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix the CAMP planId so that it is...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Set the CAMP planId as an attribu...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#issuecomment-85628841
You can disable `ConfigKey` inheritance, see https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/entity/basic/ServiceStateLogic.java#L378 for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Set the CAMP planId as an attribu...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#issuecomment-85629831
@neykov that's interesting... I'll maybe change the code, then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix the CAMP planId so that it is...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#issuecomment-85664842
+1, I don't see potential problems with rebinding, good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix the CAMP planId so that it is...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/569#discussion_r27065267
--- Diff: utils/common/src/main/java/brooklyn/config/ConfigInheritance.java ---
@@ -18,9 +18,11 @@
*/
package brooklyn.config;
+import java.io.Serializable;
+
import com.google.common.annotations.Beta;
-public abstract class ConfigInheritance {
+public abstract class ConfigInheritance implements Serializable {
--- End diff --
Add `serialVersionUID` to avoid warnings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---