You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/06 19:05:27 UTC
[GitHub] [thrift] belugabehr opened a new pull request #2131: THRIFT-5197: TSSLTransportFactory Buries NOT_OPEN Exception Type for …
belugabehr opened a new pull request #2131:
URL: https://github.com/apache/thrift/pull/2131
…Client
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [X] Did you squash your changes to a single commit? (not required, but preferred)
- [X] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [X] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr edited a comment on pull request #2131: THRIFT-5197: TSSLTransportFactory Buries NOT_OPEN Exception Type for …
Posted by GitBox <gi...@apache.org>.
belugabehr edited a comment on pull request #2131:
URL: https://github.com/apache/thrift/pull/2131#issuecomment-624891110
Might also be nice to have subclasses instead of having to pass a number into the constructor manually, but should be addressed in a separate ticket
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2131: THRIFT-5197: TSSLTransportFactory Buries NOT_OPEN Exception Type for …
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2131:
URL: https://github.com/apache/thrift/pull/2131#issuecomment-624891110
Might also be nice to have subclasses instead of having to pass a number into the constructor manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2131: THRIFT-5197: TSSLTransportFactory Buries NOT_OPEN Exception Type for …
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2131:
URL: https://github.com/apache/thrift/pull/2131#issuecomment-624892051
And for completeness sake, I came across this issue using Hive's 'beeline' utility. It's a lightweight SQL client that ships with Apache Hive. During an SSL initialization error, I was getting an "unknown error" message,... which was less than helpful. :)
https://github.com/apache/hive/blob/c3007d497ca58c595da8bd78455538a1ce0e3485/beeline/src/java/org/apache/hive/beeline/BeeLine.java#L2180-L2182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2131: THRIFT-5197: TSSLTransportFactory Buries NOT_OPEN Exception Type for …
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2131:
URL: https://github.com/apache/thrift/pull/2131#issuecomment-624858929
Looks good to me. I always wondered if we should forbid throwingsuch kind of exeptions without error code at all. The error code should be mandatory. Personal opinion of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org