[GitHub] [royale-asjs] estanglerbm commented on issue #947: XML throws parsing exception after it removes all whitespace between attributes if CRLF (\r\n) appears

[GitBox <gi...@apache.org>]

estanglerbm commented on issue #947:
URL: https://github.com/apache/royale-asjs/issues/947#issuecomment-732261823


   My impression was that the places where trimXMLWhitespace() is used is solely for trimming leading and trailing space for the entire string (whether that's right or wrong), not embedded whitespace within the string (which seem to be handled already during parsing).  But I haven't traced through in detail.
   
   So something like StringUtil.trim(), as opposed to replace() matching newlines.   However, StringUtil.trim() is probably too slow.  Perhaps changing "/gm" to "/g" is enough (turn off multi-line in the regexp);  docs seem to indicate that in an example.  Or not trimming at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org