You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2017/02/13 16:55:26 UTC
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/1440
Remove nullptr instances that were introduced from upstream backports\u2026
\u2026 and replace them with NULL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver remove_nullptr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1440
----
commit bb146e2b8484fd051bd7176c9b5e6f64cfa1b732
Author: Phil Sorber <so...@apache.org>
Date: 2017-02-13T16:54:39Z
Remove nullptr instances that were introduced from upstream backports and replace them with NULL.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/1440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1440
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1429/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1440
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/100/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1440
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1536/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1440#discussion_r100845545
--- Diff: lib/raft/raft_impl.h ---
@@ -338,8 +338,8 @@ template <typename Server> class RaftImpl : public Raft<Server>
if (!i_am_leader())
return;
// Attempt to pass leadership to a worthy successor.
- const ::std::string *best_node = nullptr;
- NodeState *best = nullptr;
+ const ::std::string *best_node = NULL;
+ NodeState *best = NULL;
--- End diff --
NBD, but this instance isn't from an upstream backport, right? This has been nullptr since inception in 38e1d741f2056a7893a0a90452d37a29ae9bf707, which goes back to 6.0.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1440#discussion_r100867264
--- Diff: lib/raft/raft_impl.h ---
@@ -338,8 +338,8 @@ template <typename Server> class RaftImpl : public Raft<Server>
if (!i_am_leader())
return;
// Attempt to pass leadership to a worthy successor.
- const ::std::string *best_node = nullptr;
- NodeState *best = nullptr;
+ const ::std::string *best_node = NULL;
+ NodeState *best = NULL;
--- End diff --
Yeah, but I figured just to be complete. Perhaps @SolidWallOfCode or @zwoop has a different opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---