You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2013/11/26 23:10:20 UTC

Review Request 15864: HIVE-4485 - beeline prints null as empty strings

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15864/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-4485
    https://issues.apache.org/jira/browse/HIVE-4485


Repository: hive-git


Description
-------

beeline is printing nulls as emtpy strings. There was no way to distinguish between an empty string an a null value. 
This is inconsistent with hive cli and other databases, they print null as "NULL" string.


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java bc2f4d8 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 0884b16 
  beeline/src/java/org/apache/hive/beeline/BufferedRows.java fc8e62b 
  beeline/src/java/org/apache/hive/beeline/Rows.java a66e709 
  beeline/src/main/resources/BeeLine.properties 9947007 
  beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java e3c6a72 

Diff: https://reviews.apache.org/r/15864/diff/


Testing
-------

unit tests included. Also tested manually.


Thanks,

Thejas Nair

Re: Review Request 15864: HIVE-4485 - beeline prints null as empty strings

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15864/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 10:39 p.m.)


Review request for hive.


Changes
-------

Fixes whitespace issues. Adds missing BooleanCompletor file.


Bugs: HIVE-4485
    https://issues.apache.org/jira/browse/HIVE-4485


Repository: hive-git


Description
-------

beeline is printing nulls as emtpy strings. There was no way to distinguish between an empty string an a null value. 
This is inconsistent with hive cli and other databases, they print null as "NULL" string.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java bc2f4d8 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 0884b16 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BufferedRows.java fc8e62b 
  beeline/src/java/org/apache/hive/beeline/Rows.java a66e709 
  beeline/src/main/resources/BeeLine.properties 9947007 
  beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java e3c6a72 

Diff: https://reviews.apache.org/r/15864/diff/


Testing
-------

unit tests included. Also tested manually.


Thanks,

Thejas Nair