You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/01/19 09:05:01 UTC
[GitHub] [cassandra-dtest] tlasica opened a new pull request #113: CASSANDRA-16395. Explicit node start timeouts.
tlasica opened a new pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113
Some tests require longer start timeout than default 90s:
* bootstrap with reset state
* node replacement
* cdc tests (due to checks for other seeds connectivity)
Before: use default timeout, 90s or rather 600s (due to bug in ccm)
After: use explicit timeout per test case: 120s or 180s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] tlasica commented on a change in pull request #113: CASSANDRA-16395. Explicit node start timeouts.
Posted by GitBox <gi...@apache.org>.
tlasica commented on a change in pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113#discussion_r560032516
##########
File path: cdc_test.py
##########
@@ -547,7 +547,7 @@ def _init_new_loading_node(self, ks_name, create_stmt, use_thrift=False):
logger.debug('adding node')
self.cluster.add(loading_node, is_seed=True)
logger.debug('starting new node')
- loading_node.start(wait_for_binary_proto=True)
+ loading_node.start(wait_for_binary_proto=120)
Review comment:
instead of increasing timeout we could use some magical flag
to skip seed node2 seed connection checking (as node1 is down and node2 is also a seed).
this is new "safety guard" in C* 4.0, but I have not found any switch to turn it off...
I was considering to make timeout conditional for 4.0 but this would imo bring a little value with added code complexity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever closed pull request #113: CASSANDRA-16395. Explicit node start timeouts.
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever commented on pull request #113: CASSANDRA-16395. Explicit node start timeouts.
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113#issuecomment-764622652
Committed with https://github.com/apache/cassandra-dtest/commit/e8c2b94b6f106e276800aa3de2628a73a70ac5e6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever closed pull request #113: CASSANDRA-16395. Explicit node start timeouts.
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever commented on pull request #113: CASSANDRA-16395. Explicit node start timeouts.
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #113:
URL: https://github.com/apache/cassandra-dtest/pull/113#issuecomment-764622652
Committed with https://github.com/apache/cassandra-dtest/commit/e8c2b94b6f106e276800aa3de2628a73a70ac5e6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org