You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/24 21:17:17 UTC

[kudu-CR] java: fix errorprone warnings 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13431

to review the following change.


Change subject: java: fix errorprone warnings
......................................................................

java: fix errorprone warnings

kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java:85: warning: [EqualsGetClass] Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
    public boolean equals(Object o) {
                   ^

kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:118: warning: [UnusedVariable] The field 'PERCENTAGE_RANGE' is never read.
  private static final Range<Float> PERCENTAGE_RANGE = Range.closed(0.0f, 1.0f);
                                    ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line or 'static { Range.closed(0.0f, 1.0f); }'?

Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
2 files changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/13431/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: fix errorprone warnings

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 25 May 2019 00:27:33 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix errorprone warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] java: fix errorprone warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................


Patch Set 1: Verified+1

Overriding Jenkins, NTP synchronization issue for one test.


-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 22:21:41 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix errorprone warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................


Patch Set 2: Verified+1

Overriding Jenkins, NTP killed one test and a known flake hit the other.


-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 May 2019 22:03:28 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix errorprone warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: java: fix errorprone warnings
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] java: fix errorprone warnings

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 May 2019 03:35:29 +0000
Gerrit-HasComments: No

[kudu-CR] java: fix errorprone warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13431 )

Change subject: java: fix errorprone warnings
......................................................................

java: fix errorprone warnings

kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java:85: warning: [EqualsGetClass] Overriding Object#equals in a non-final class by using getClass rather than instanceof breaks substitutability of subclasses.
    public boolean equals(Object o) {
                   ^

kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:118: warning: [UnusedVariable] The field 'PERCENTAGE_RANGE' is never read.
  private static final Range<Float> PERCENTAGE_RANGE = Range.closed(0.0f, 1.0f);
                                    ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line or 'static { Range.closed(0.0f, 1.0f); }'?

Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Reviewed-on: http://gerrit.cloudera.org:8080/13431
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd36b2bbd7b591b08661838d68584f152b1aaab
Gerrit-Change-Number: 13431
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>