You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/17 03:40:48 UTC

[GitHub] [shardingsphere-elastic-job-lite] mmx1960 opened a new pull request #781: Remove instance node in register server when shutdown (#780)

mmx1960 opened a new pull request #781:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/781


   Fixes #780.
   
   Changes proposed in this pull request:
   - remove instance node in register server when shutdown
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elastic-job-lite] Technoboy- commented on a change in pull request #781: Remove instance node in register server when shutdown (#780)

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #781:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/781#discussion_r441266063



##########
File path: elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobRegistry.java
##########
@@ -167,6 +168,8 @@ public void shutdown(final String jobName) {
         CoordinatorRegistryCenter regCenter = regCenterMap.remove(jobName);
         if (null != regCenter) {
             regCenter.evictCacheData("/" + jobName);
+            //fix #780 remove instance in register server , place here ensure job `isShutdown`

Review comment:
       No need to comment this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elastic-job-lite] Technoboy- commented on pull request #781: Remove instance node in register server when shutdown (#780)

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #781:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/781#issuecomment-645303604


   JobShutdownHookPlugin#shutdown has removed the instance. Please take a look and confirm . 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org