You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2025/01/14 13:42:00 UTC

[jira] [Created] (OAK-11389) Disable Checkstyle

Konrad Windszus created OAK-11389:
-------------------------------------

             Summary: Disable Checkstyle
                 Key: OAK-11389
                 URL: https://issues.apache.org/jira/browse/OAK-11389
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: parent
            Reporter: Konrad Windszus
            Assignee: Konrad Windszus


We don’t leverage any automated formatters nor provide a clear guidance on code formatting (https://jackrabbit.apache.org/oak/docs/participating.html#coding-style)
Still there is the checkstyle-maven-plugin being used which emits tons of errors with profile “pedantic” and “release” (https://github.com/apache/jackrabbit-oak/blob/fe9c04c3b567386dfb5d262971a278cd2c634a86/oak-parent/pom.xml#L1056).

In addition checkstyle is leveraging the default ruleset sun_checks.xml (which I consider outdated these days with a limitation of 80 chars per line), https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#configLocation, but we explicitly don’t fail the build.

As noone cared in the past 10 years to fix Checkstyle issues it is time to remove that plugin.

Compare with discussion in https://lists.apache.org/thread/wl1m3fnk8dchvttkmgco8s1wdq0376yq



--
This message was sent by Atlassian Jira
(v8.20.10#820010)