[GitHub] [airflow] Taragolis commented on a diff in pull request #27947: refactored Amazon Redshift-data functionality into the hook

[GitBox <gi...@apache.org>]

Taragolis commented on code in PR #27947:
URL: https://github.com/apache/airflow/pull/27947#discussion_r1037021292


##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -99,67 +97,29 @@ def __init__(
             )
         self.aws_conn_id = aws_conn_id
         self.region = region
-        self.statement_id = None
+        self.statement_id: str | None = None
 
     @cached_property
     def hook(self) -> RedshiftDataHook:
         """Create and return an RedshiftDataHook."""
         return RedshiftDataHook(aws_conn_id=self.aws_conn_id, region_name=self.region)
 
-    def execute_query(self):
-        kwargs: dict[str, Any] = {

Review Comment:
   This also not a good idea to remove any public methods. Instead of remove we need to deprecate it and keep backward compatibility for a while.
   
   Some of users might create own operators based on `RedshiftDataOperator` and use this methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org