You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/03/29 07:27:23 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1396: [CELEBORN-488] [FLINK] Calculate required shuffle memory before allocating slots if resources are specified
RexXiong opened a new pull request, #1396:
URL: https://github.com/apache/incubator-celeborn/pull/1396
…er requirement
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
implements computeShuffleMemorySizeForTask for remote shuffle service
### Why are the changes needed?
see [FLINK-15031](https://github.com/apache/flink/pull/16173)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on pull request #1396: [CELEBORN-488] [FLINK] Calculate required shuffle memory before allocating slots if resources are specified
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #1396:
URL: https://github.com/apache/incubator-celeborn/pull/1396#issuecomment-1488102892
ping @zhongqiangczq
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1396: [CELEBORN-488] [FLINK] Calculate required shuffle memory before allocating slots if resources are specified
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1396:
URL: https://github.com/apache/incubator-celeborn/pull/1396#issuecomment-1488090575
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1396?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1396](https://codecov.io/gh/apache/incubator-celeborn/pull/1396?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (699ec8f) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/cbe65a7e2e25b81601c996fa12ac897c3b4ae9fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cbe65a7) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1396 +/- ##
============================================
+ Coverage 29.85% 29.91% +0.06%
- Complexity 913 919 +6
============================================
Files 223 223
Lines 18664 18678 +14
Branches 1987 1989 +2
============================================
+ Hits 5571 5586 +15
- Misses 12699 12702 +3
+ Partials 394 390 -4
```
[see 7 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1396/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq merged pull request #1396: [CELEBORN-488] [FLINK] Calculate required shuffle memory before allocating slots if resources are specified
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq merged PR #1396:
URL: https://github.com/apache/incubator-celeborn/pull/1396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org