You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "dingshuangxi888 (via GitHub)" <gi...@apache.org> on 2024/03/22 07:04:33 UTC

[PR] [ISSUE #7955]Don't set default auth metadata provider [rocketmq]

dingshuangxi888 opened a new pull request, #7956:
URL: https://github.com/apache/rocketmq/pull/7956

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   Fixes #7955
   
   ### Brief Description
   
   Don't set default auth metadata provider
   
   ### How Did You Test This Change?
   
   Don't set default auth metadata provider
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #7955] Don't set default auth metadata provider [rocketmq]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7956:
URL: https://github.com/apache/rocketmq/pull/7956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #7955]Don't set default auth metadata provider [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7956:
URL: https://github.com/apache/rocketmq/pull/7956#issuecomment-2014505592

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7956?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `31.81818%` with `15 lines` in your changes are missing coverage. Please review.
   > Project coverage is 42.83%. Comparing base [(`f2dd5b0`)](https://app.codecov.io/gh/apache/rocketmq/commit/f2dd5b06fe7ba39fd886d86b8c49c306dfbc2024?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6245b45`)](https://app.codecov.io/gh/apache/rocketmq/pull/7956?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   > :exclamation: Current head 6245b45 differs from pull request most recent head f8f9b88. Consider uploading reports for the commit f8f9b88 to get more accurate results
   
   | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7956?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...tion/manager/AuthorizationMetadataManagerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL21hbmFnZXIvQXV0aG9yaXphdGlvbk1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | 40.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...entication/chain/DefaultAuthenticationHandler.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9jaGFpbi9EZWZhdWx0QXV0aGVudGljYXRpb25IYW5kbGVyLmphdmE=) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../authentication/factory/AuthenticationFactory.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9mYWN0b3J5L0F1dGhlbnRpY2F0aW9uRmFjdG9yeS5qYXZh) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ion/manager/AuthenticationMetadataManagerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9tYW5hZ2VyL0F1dGhlbnRpY2F0aW9uTWV0YWRhdGFNYW5hZ2VySW1wbC5qYXZh) | 50.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...h/authorization/chain/AclAuthorizationHandler.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL2NoYWluL0FjbEF1dGhvcml6YXRpb25IYW5kbGVyLmphdmE=) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../authorization/chain/UserAuthorizationHandler.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL2NoYWluL1VzZXJBdXRob3JpemF0aW9uSGFuZGxlci5qYXZh) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...th/authorization/factory/AuthorizationFactory.java](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRob3JpemF0aW9uL2ZhY3RvcnkvQXV0aG9yaXphdGlvbkZhY3RvcnkuamF2YQ==) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #7956      +/-   ##
   =============================================
   - Coverage      42.85%   42.83%   -0.02%     
   + Complexity     10355    10348       -7     
   =============================================
     Files           1270     1270              
     Lines          88594    88604      +10     
     Branches       11393    11396       +3     
   =============================================
   - Hits           37965    37955      -10     
   - Misses         45952    45965      +13     
   - Partials        4677     4684       +7     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7956?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org