You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2025/09/28 01:11:14 UTC

[PR] Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

porcelli opened a new pull request, #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293

   This ports CI and release-related changes made for the 10.1.0 release into the main branch.
   
   Closes: https://github.com/apache/incubator-kie-issues/issues/2119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3670365800

   Go ahead and merge. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm commented on PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3670127851

   Thanks @LightGuard for your quick response!
   Unfortunately Merging is blocked with the changes you requested. When you have a spare moment could you please approve the PR or revert the change request.
   Thanks again, and hope you have a great holiday season with the family! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on code in PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#discussion_r2427296041


##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
         timeout(time: 180, unit: 'MINUTES')
     }
 
+    environment {
+        MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml -Dmaven.repo.local=${WORKSPACE}/.maven"
+    }
+
     parameters {
-        string(name: 'BRANCH_NAME', description: 'Set the Git branch to checkout (0.0.x)', trim: true)
-        string(name: 'RELEASE_VERSION', description: 'Release version', trim: true)
-        string(name: 'TAG_NAME', description: 'Tag name to be created', trim: true)
-        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
 dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+        string(name: 'BRANCH_NAME', description: 'Set the Git branch to checkout (0.0.x)', trim: true, defaultValue: '10.1.x')
+        string(name: 'RELEASE_VERSION', description: 'Release version', trim: true, defaultValue: '10.1.0')
+        string(name: 'RELEASE_CANDIDATE_VERSION', description: 'Release candidate version', trim: true, defaultValue: '10.1.0-rc1')

Review Comment:
   Does a build need to define each of these, or only one? I would think that you'd need both RELEASE_VERSION and the CANDIDATE_VERSION would get appended if it was given. Without any additional information in the descriptions this is confusing.



##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
         timeout(time: 180, unit: 'MINUTES')
     }
 
+    environment {
+        MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml -Dmaven.repo.local=${WORKSPACE}/.maven"
+    }
+
     parameters {
-        string(name: 'BRANCH_NAME', description: 'Set the Git branch to checkout (0.0.x)', trim: true)
-        string(name: 'RELEASE_VERSION', description: 'Release version', trim: true)
-        string(name: 'TAG_NAME', description: 'Tag name to be created', trim: true)
-        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
 dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+        string(name: 'BRANCH_NAME', description: 'Set the Git branch to checkout (0.0.x)', trim: true, defaultValue: '10.1.x')
+        string(name: 'RELEASE_VERSION', description: 'Release version', trim: true, defaultValue: '10.1.0')
+        string(name: 'RELEASE_CANDIDATE_VERSION', description: 'Release candidate version', trim: true, defaultValue: '10.1.0-rc1')
+        string(name: 'TAG_NAME', description: 'Tag name to be created', trim: true, defaultValue: '10.1.0-rc1')

Review Comment:
   Why would the tag name be anything different than RELEASE_VERSION + CANDIDATE_VERSION?



##########
.ci/jenkins/release-jobs/Jenkinsfile.dev-deployment-quarkus-blank-app-image:
##########
@@ -23,14 +23,15 @@ pipeline {
     }
 
     options {
-        timeout(time: 60, unit: 'MINUTES')
+        timeout(time: 180, unit: 'MINUTES')

Review Comment:
   It can take 3 hours for this one to run?



##########
.ci/jenkins/release-jobs/Jenkinsfile.serverless-logic-web-tools-swf-builder-image:
##########
@@ -31,6 +31,7 @@ pipeline {
         string(description: 'Release Version', name: 'RELEASE_VERSION', defaultValue: '0.0.0')
         string(description: 'Base Ref', name: 'BASE_REF')
         string(description: 'Release Candidate Version', name: 'RELEASE_CANDIDATE_VERSION', defaultValue: '')
+        string(name: 'PIPELINE_PATH', description: 'Path to run the pipeline')

Review Comment:
   A number of these jobs have this param in them, is it supposed to point to the URL of the job to run? The Jenkinsfile?



##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
         timeout(time: 180, unit: 'MINUTES')
     }
 
+    environment {
+        MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml -Dmaven.repo.local=${WORKSPACE}/.maven"

Review Comment:
   Is `kie-settings.xml` within the docker image, or should it be added to this PR as well?



##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -164,19 +170,21 @@ pipeline {
                     script {
                         githubUtils.createTag("${params.TAG_NAME}")
                         githubUtils.pushObject('origin', "${params.TAG_NAME}", "${pipelineVars.asfGithubPushCredentialsId}")
+                        sleep(time: 1, unit: 'MINUTES') // Wait for the tag to be created

Review Comment:
   Might a `waitUntil` step that checks for the existence of the remote tag work better here than sleep?



##########
.ci/jenkins/Jenkinsfile.release-publish:
##########
@@ -31,7 +31,7 @@ pipeline {
 
     parameters {
         string(description: 'Release Version', name: 'RELEASE_VERSION', defaultValue: '0.0.0')
-        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
 dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_cdn":"tr
 ue","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')        

Review Comment:
   I think this needs to happen and in multiple places. We have a number of "dev_deployment_quakus" instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3662565467

   @LightGuard, most of your review comments make sense - however I want to point out that this is a cherry pick from 10.1.0 release; so for a clean visible history I'd prefer if we could merge as is and - once merged - o can make the adjustments on top.
   
   wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm merged PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#discussion_r2384418254


##########
.ci/jenkins/ci-jobs/Jenkinsfile.ci-check-codeql:
##########
@@ -44,7 +44,7 @@ pipeline {
         stage('Check code quality') {
             agent {
                 docker {
-                    image "docker.io/apache/incubator-kie-tools-ci-build:${env.BRANCH_NAME}"
+                    image "docker.io/apache/incubator-kie-tools-ci-build:main'

Review Comment:
   Missing closing quote in Docker image string. Should be `main\"` instead of `main'`.
   ```suggestion
                       image "docker.io/apache/incubator-kie-tools-ci-build:main"
   ```



##########
.ci/jenkins/Jenkinsfile.release-publish:
##########
@@ -31,7 +31,7 @@ pipeline {
 
     parameters {
         string(description: 'Release Version', name: 'RELEASE_VERSION', defaultValue: '0.0.0')
-        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
 dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+        string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_cdn":"tr
 ue","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')        

Review Comment:
   Typo in JSON key: `dev_deployment_quakus_blank_app_image` should be `dev_deployment_quarkus_blank_app_image` (missing 'r' in 'quarkus').
   ```suggestion
           string(description: 'Runners', name: 'RUNNERS', defaultValue: '{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_quarkus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_cdn":
 "true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')        
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm commented on PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3463985573

   Hi @porcelli 
   Thanks for this! I didn't realize you had already started this process and I created a PR here: https://github.com/apache/incubator-kie-tools/pull/3314. I've addressed Jason's comments in it as well. Are you okay if I close this and we continue with that PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#2119: Port CI related changes for 10.1.0 back to main branch [incubator-kie-tools]

Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on PR #3293:
URL: https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3662575419

   Yeah, that’s fine with me.
   
   Sent from Gmail Mobile
   
   
   On Tue, Dec 16, 2025 at 14:52 Alex Porcelli ***@***.***>
   wrote:
   
   > *porcelli* left a comment (apache/incubator-kie-tools#3293)
   > <https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3662565467>
   >
   > @LightGuard <https://github.com/LightGuard>, most of your review comments
   > make sense - however I want to point out that this is a cherry pick from
   > 10.1.0 release; so for a clean visible history I'd prefer if we could merge
   > as is and - once merged - o can make the adjustments on top.
   >
   > wdyt?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-kie-tools/pull/3293#issuecomment-3662565467>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAAHKE32YLKNJG5OTPK5F234CB5IVAVCNFSM6AAAAACHV6JMQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRSGU3DKNBWG4>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org