You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by ilkkavi <gi...@git.apache.org> on 2018/03/02 12:26:35 UTC
[GitHub] activemq-artemis pull request #1920: Added acknowledgements for messages exp...
GitHub user ilkkavi opened a pull request:
https://github.com/apache/activemq-artemis/pull/1920
Added acknowledgements for messages expired without expiry address bindings
Referring to a resource leak and JMX reporting expired messages as in-delivery as discussed in the user mailing list between 2018-02-21 and 2018-03-01. I was unable to reproduce the OOM after this change. Would you care to comment on this, if possible?
http://activemq.2283324.n4.nabble.com/Artemis-2-4-0-Issues-with-memory-leaks-and-JMS-message-redistribution-td4736891.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilkkavi/activemq-artemis expiry-memoryleak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1920
----
commit c9e544b19e8990cf28798df239f83248d2aae07d
Author: Ilkka Virolainen <il...@...>
Date: 2018-03-02T12:18:40Z
Added acknowledgements for messages expired without expiry address bindings
----
---
[GitHub] activemq-artemis issue #1920: Added acknowledgements for messages expired wi...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1920
I wanted to keep your commit, but I also wanted to get this merged so it can be included in the upcoming 2.5 release. Therefore, I sent #1930 which has your commit with and updated commit message (to reference the JIRA) as well as a few tests to reproduce the issue and ensure no regressions later. Please close this PR. Thanks!
---
[GitHub] activemq-artemis issue #1920: Added acknowledgements for messages expired wi...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1920
This change needs a JIRA and a test as well.
---
[GitHub] activemq-artemis issue #1920: Added acknowledgements for messages expired wi...
Posted by ilkkavi <gi...@git.apache.org>.
Github user ilkkavi commented on the issue:
https://github.com/apache/activemq-artemis/pull/1920
Excellent, thank you!
---
[GitHub] activemq-artemis pull request #1920: Added acknowledgements for messages exp...
Posted by ilkkavi <gi...@git.apache.org>.
Github user ilkkavi closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1920
---