[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27637: [SPARK-30874][SQL] Support Postgres Kerberos login in JDBC connector

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #27637: [SPARK-30874][SQL] Support Postgres Kerberos login in JDBC connector
URL: https://github.com/apache/spark/pull/27637#discussion_r382513091
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
 ##########
 @@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.jdbc.connection
+
+import java.sql.{Connection, Driver}
+
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions
+
+/**
+ * Connection provider which opens connection toward various databases (database specific instance
+ * needed). If authentication required then it's the provider's responsibility to set all the
+ * parameters.
+ */
+private[jdbc] trait ConnectionProvider {
+  def getConnection(): Connection
+}
+
+private[jdbc] object ConnectionProvider extends Logging {
+  def create(driver: Driver, options: JDBCOptions): ConnectionProvider = {
+    if (options.keytab == null || options.principal == null) {
+      logInfo("No authentication configuration found, using basic connection provider")
+      new BasicConnectionProvider(driver, options)
+    } else {
+      logInfo("Authentication configuration found, using database specific connection provider")
+      options.driverClass match {
+        case PostgresConnectionProvider.driverClass =>
+          logInfo("Postgres connection provider found")
 
 Review comment:
   Fixed (just to make it consistent I've lowered line 37 as well).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org