You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "sepe81 (via GitHub)" <gi...@apache.org> on 2024/01/26 11:52:04 UTC
[PR] various dependency updates for master [struts]
sepe81 opened a new pull request, #863:
URL: https://github.com/apache/struts/pull/863
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1920763414
Ok, looks like my idea with merging patch versions without a JIRA ticket is ok. Could you create a ticket to cover upgrade of Log4j from 2.20.0 to 2.21.1? This is the only major/minor upgrade in this PR. Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #863:
URL: https://github.com/apache/struts/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1912576475
It fails on Log4j as here https://github.com/apache/struts/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "sepe81 (via GitHub)" <gi...@apache.org>.
sepe81 commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1920822211
see https://issues.apache.org/jira/browse/WW-5389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1918650258
I just create a simple Dependency task in JIRA with a title explaining what is going to be upgraded like here [WW-5347](https://issues.apache.org/jira/browse/WW-5347). Yet I wonder if need to report any patch version upgrade, if all the tests passed everything should be fine. Let me ask this on the Dev group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "sepe81 (via GitHub)" <gi...@apache.org>.
sepe81 commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1917656002
@lukaszlenart ready to merge or do you see any further issue? I would like to cherry pick this to v7 afterwards and add a commit for WW-5384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1913158574
I created ticket [WW-5384](https://issues.apache.org/jira/browse/WW-5384) to address Log4j in S7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "sepe81 (via GitHub)" <gi...@apache.org>.
sepe81 commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1913084815
Okay, there seems to be some minor problem with error_prone_annotations. I'll try to solve it.
Warning:
Dependency convergence error for com.google.errorprone:error_prone_annotations:jar:2.23.0:compile paths to dependency are:
+-org.apache.struts:struts2-showcase:war:6.4.0-SNAPSHOT
+-org.apache.logging.log4j:log4j-api:jar:2.22.1:compile
+-com.google.errorprone:error_prone_annotations:jar:2.23.0:compile
and
+-org.apache.struts:struts2-showcase:war:6.4.0-SNAPSHOT
+-org.apache.struts:struts2-core:jar:6.4.0-SNAPSHOT:compile
+-com.github.ben-manes.caffeine:caffeine:jar:2.9.3:compile
+-com.google.errorprone:error_prone_annotations:jar:2.10.0:compile
Error: Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] various dependency updates for master [struts]
Posted by "sepe81 (via GitHub)" <gi...@apache.org>.
sepe81 commented on PR #863:
URL: https://github.com/apache/struts/pull/863#issuecomment-1913089511
Unfortunately, [error_prone_annotations > 2.10.0 depends on Java 11](https://github.com/google/error-prone/releases/tag/v2.11.0) – so an upgrade is not an option for now.
I'll downgrade log4j2 to 2.21.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org