You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/01/13 17:05:46 UTC

Review Request 29850: RMF checks existence of hbase_2_2_* packages incorrectly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29850/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9106
    https://issues.apache.org/jira/browse/AMBARI-9106


Repository: ambari


Description
-------

STR:
1) Install multinode cluster
2) Imagine that cluster deployment fails on node host1 (strictly at the same time when some package like hbase_2_2_* is installed on any other node host2)
3) Now ambari-server sends CANCEL commands to all hosts, and agent on host2 kills yum process during installation. As a result, some hbase_2_2_* packages are installed and some are not.
3) Retry cluster installation once more.
4) On host2, full package set for hbase_2_2_* is never installed


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestPackageResource.py 73f0a9d 
  ambari-common/src/main/python/resource_management/core/providers/package/apt.py 44a67de 
  ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 82c8e82 
  ambari-common/src/main/python/resource_management/core/providers/package/zypper.py e532c1a 

Diff: https://reviews.apache.org/r/29850/diff/


Testing
-------

Manual tests under centos6, sles, ubuntu

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.171s]
[INFO] Ambari Server ..................................... SUCCESS [32.144s]
[INFO] Ambari Agent ...................................... SUCCESS [21.095s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56.073s
[INFO] Finished at: Tue Jan 13 18:46:43 FET 2015
[INFO] Final Memory: 41M/424M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 29850: RMF checks existence of hbase_2_2_* packages incorrectly

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29850/#review67902
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 13, 2015, 11:05 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29850/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 11:05 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9106
>     https://issues.apache.org/jira/browse/AMBARI-9106
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 1) Install multinode cluster
> 2) Imagine that cluster deployment fails on node host1 (strictly at the same time when some package like hbase_2_2_* is installed on any other node host2)
> 3) Now ambari-server sends CANCEL commands to all hosts, and agent on host2 kills yum process during installation. As a result, some hbase_2_2_* packages are installed and some are not.
> 3) Retry cluster installation once more.
> 4) On host2, full package set for hbase_2_2_* is never installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 73f0a9d 
>   ambari-common/src/main/python/resource_management/core/providers/package/apt.py 44a67de 
>   ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 82c8e82 
>   ambari-common/src/main/python/resource_management/core/providers/package/zypper.py e532c1a 
> 
> Diff: https://reviews.apache.org/r/29850/diff/
> 
> 
> Testing
> -------
> 
> Manual tests under centos6, sles, ubuntu
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.171s]
> [INFO] Ambari Server ..................................... SUCCESS [32.144s]
> [INFO] Ambari Agent ...................................... SUCCESS [21.095s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 56.073s
> [INFO] Finished at: Tue Jan 13 18:46:43 FET 2015
> [INFO] Final Memory: 41M/424M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>