You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/26 22:16:44 UTC
[GitHub] [spark] zero323 opened a new pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
zero323 opened a new pull request #29879:
URL: https://github.com/apache/spark/pull/29879
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699557647
**[Test build #129137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129137/testReport)** for PR 29879 at commit [`d996c6e`](https://github.com/apache/spark/commit/d996c6e32d8fcb688ed102fcbd576c1d0367df92).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702945228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701029264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702933624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702945228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702909163
**[Test build #129361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129361/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702909608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702909608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704118197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34045/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702945212
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33974/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702917444
**[Test build #129364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129364/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704823263
**[Test build #129499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129499/testReport)** for PR 29879 at commit [`c714a1c`](https://github.com/apache/spark/commit/c714a1c43413e7836e8aa7f9cbcce7235fe1dd59).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29879:
URL: https://github.com/apache/spark/pull/29879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704832149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702933177
**[Test build #129364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129364/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701001014
**[Test build #129253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129253/testReport)** for PR 29879 at commit [`037acdd`](https://github.com/apache/spark/commit/037acddf0ed56328f5e7021f48d6acf09d126da3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699555766
**[Test build #129137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129137/testReport)** for PR 29879 at commit [`d996c6e`](https://github.com/apache/spark/commit/d996c6e32d8fcb688ed102fcbd576c1d0367df92).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701890500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704288127
> Hmm, but technically `python/join.pyi` and `python/rddsampler.pyi` are not documented so far. I believe they are for internal purposes. I got that many undocumented stuffs can be useful (also in Scala or Java sides) but I would prefer to hide it unless we explicitly document and expose.
Fair point. If you feel strong about these, I'll be happy to remove them. But I think we need a bit precise criteria of inclusion / exclusion in a long run. In general the most important factors are:
- Stability, which influences cost of maintenance.
- Precision of annotations, which influences potential usefulness (I avoided annotating many parts of the "internal" API, primarily because possible annotations would be far to generic to be useful).
- Likelihood that given part of the API will be used by the end users.
- Direct cost of not including (amount of ignores required for things to type check now, and possibly in the future, if we decide to switch to inline variants).
(I am primarily thinking about SPARK-33003 here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704118129
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34045/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704118181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702935960
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33974/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701011952
**[Test build #129253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129253/testReport)** for PR 29879 at commit [`037acdd`](https://github.com/apache/spark/commit/037acddf0ed56328f5e7021f48d6acf09d126da3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702917444
**[Test build #129364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129364/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701895149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704806167
Thanks @zero323.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704089140
Hmm, but technically `python/join.pyi` and `python/rddsampler.pyi` are not documented so far. I believe they are for internal purposes. I got that many undocumented stuffs can be useful (also in Scala or Java sides) but I would prefer to hide it unless we explicitly document and expose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701903035
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704841831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701172961
**[Test build #129263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129263/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701198727
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33880/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701903042
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33916/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704841807
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704841831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702915068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704102922
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34045/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701172961
**[Test build #129263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129263/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701903035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699555766
**[Test build #129137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129137/testReport)** for PR 29879 at commit [`d996c6e`](https://github.com/apache/spark/commit/d996c6e32d8fcb688ed102fcbd576c1d0367df92).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701012325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702915567
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701182156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701890144
**[Test build #129300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129300/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699559970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701879933
**[Test build #129300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129300/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704629549
I personally tend to agree with what you listed up. However, one concern is that it doesn't work well out of the box when the criteria becomes verbose especially for new contributors given my experience - the same criteria is interpreted differently often. So I ended up with focusing on simplifying it unless it's required.
Also, one more thing is that I would like to be explicit what we expose and hide as APIs. Something has been internal so it was changed but users ended up with complaining - this happens not very often but not so rarely. I would like to avoid this kind of cost.
To sum up, we can keep `python/join.pyi` and `python/rddsampler.pyi` but let's make sure these are special cases. Do the removal of both, for example, cause many ignores? If that's the case, we can keep probably with leaving some comments. Otherwise, let's remove both and start with the simpler set ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702898055
**[Test build #129361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129361/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702915068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701181838
**[Test build #129263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129263/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701022569
I think it is as much as we can remove here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704817709
> I personally tend to agree with what you listed up. However, one concern is that it doesn't work well out of the box when the criteria becomes verbose especially for new contributors given my experience - the same criteria is interpreted differently often. So I ended up with focusing on simplifying it unless it's required.
Makes sense. I am still thinking about this from a perspective of the main contributor :)
> Do the removal of both, for example, cause many ignores?
These two have rather limited scope so we're good for now. I didn't to make merge test, but if it becomes a problem later, we can always restore things ‒ stability works both ways here..
> If that's the case, we can keep probably with leaving some comments. Otherwise, let's remove both and start with the simpler set ..
Sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701012325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704857261
Thanks @HyukjinKwon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704092486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701198718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699557700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704118181
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704856905
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701198691
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33880/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701029264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701198718
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701182156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701877899
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701890500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699557700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702933624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704092486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701029255
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33870/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699559967
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33753/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704629549
I personally tend to agree with what you listed up. However, one concern is that it doesn't work well out of the box when the criteria becomes verbose especially for new contributors given my experience - the same criteria is interpreted differently often. So I ended up with focusing on simplifying it unless it's required.
Also, one more thing is that I would like to be explicit what we expose and hide as APIs. Something has been internal so it was changed but users ended up with complaining. I would like to avoid this kind of cost.
To sum up, we can keep `python/join.pyi` and `python/rddsampler.pyi` but let's make sure these are special cases. Do the removal of both, for example, cause many ignores? If that's the case, we can keep probably with leaving some comments. Otherwise, let's remove both and start with the simpler set ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704092119
**[Test build #129438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129438/testReport)** for PR 29879 at commit [`045834e`](https://github.com/apache/spark/commit/045834e220b20579f6b9c78bef1270e0d9f83b53).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701189063
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33880/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704823866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704805798
**[Test build #129499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129499/testReport)** for PR 29879 at commit [`c714a1c`](https://github.com/apache/spark/commit/c714a1c43413e7836e8aa7f9cbcce7235fe1dd59).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704085534
> Should we remove `python/join.pyi`,
I considered that but overall I'd prefer to keep it as-is:
- It is exposed to end user through RDD joins, but can be used directly (kind of useful, back when we still supported Python 2, not so much in 3, where we can use methods, without any caveats).
- It is stable, have useful annotations and nothing indicates it's non-public character.
> `python/rddsampler.pyi`
I don't have strong opinion about it. However, same as join, it is stable with meaningful annotations and never marked as internal (I used it once or twice directly, so I suspect that others might as well). So indicates that it will cause serious maintenance overhead or is just a deadweight.
> and `python/shell.pyi` too?
Yes, that's an omission.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701879933
**[Test build #129300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129300/testReport)** for PR 29879 at commit [`065a99f`](https://github.com/apache/spark/commit/065a99fb5d48425d4528ad1b9fd4a8864250b679).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699559970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-702898055
**[Test build #129361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129361/testReport)** for PR 29879 at commit [`341ab2a`](https://github.com/apache/spark/commit/341ab2accab5de40622d63b996ff0fa567de27fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704823866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701902891
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701023489
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33870/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-701001014
**[Test build #129253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129253/testReport)** for PR 29879 at commit [`037acdd`](https://github.com/apache/spark/commit/037acddf0ed56328f5e7021f48d6acf09d126da3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-699558867
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33753/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704805798
**[Test build #129499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129499/testReport)** for PR 29879 at commit [`c714a1c`](https://github.com/apache/spark/commit/c714a1c43413e7836e8aa7f9cbcce7235fe1dd59).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704081457
**[Test build #129438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129438/testReport)** for PR 29879 at commit [`045834e`](https://github.com/apache/spark/commit/045834e220b20579f6b9c78bef1270e0d9f83b53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29879: [SPARK-33002][PYTHON] Remove non-API annotations.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29879:
URL: https://github.com/apache/spark/pull/29879#issuecomment-704081457
**[Test build #129438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129438/testReport)** for PR 29879 at commit [`045834e`](https://github.com/apache/spark/commit/045834e220b20579f6b9c78bef1270e0d9f83b53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org